Skip to content

rust: use macro for debug output #356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
florianl merged 1 commit into from
Feb 18, 2025
Merged

rust: use macro for debug output #356

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion rust-crates/symblib/src/symbconv/dwarf/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -341,7 +341,7 @@ fn extract_ranges(
}
};

eprintln!("Processing {:?}", &unit);
debug!("Processing {:?}", &unit);
match process_unit(unit, &mut visitor) {
Ok(()) => stats.units_ok += 1,
Err(e) => {
Expand Down
6 changes: 3 additions & 3 deletions rust-crates/symblib/src/symbconv/go.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
//! This is currently still very basic and doesn't support inline functions
//! or constructing line tables.

use crate::{gosym, objfile, symbfile, AnyError};
use crate::{debug, gosym, objfile, symbfile, AnyError};
use fallible_iterator::FallibleIterator as _;

/// Result type shorthand.
Expand Down Expand Up @@ -70,7 +70,7 @@ fn extract_ranges(obj: &objfile::Reader<'_>, visitor: super::RangeVisitor<'_>) -
while let Some(func) = func_iter.next()? {
// Infer end of function from line tables.
let Some(end) = func.line_mapping()?.map(|(rng, _)| Ok(rng.end)).max()? else {
eprintln!(
debug!(
"WARN: unable to determine end of function ({})",
func.name()?
);
Expand All @@ -80,7 +80,7 @@ fn extract_ranges(obj: &objfile::Reader<'_>, visitor: super::RangeVisitor<'_>) -

let length = end.saturating_sub(func.start_addr());
if length == 0 {
eprintln!("WARN: zero function length ({})", func.name()?);
debug!("WARN: zero function length ({})", func.name()?);
stats.funcs_skipped += 1;
continue;
}
Expand Down