Skip to content

reporter/pdata: do no generate profiles if there are no events #347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
florianl merged 2 commits into from
Feb 10, 2025
Merged

reporter/pdata: do no generate profiles if there are no events #347

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
13a2dd0
reporter/pdata: do no generate profiles if there are no events
florianl Feb 10, 2025
f045a49
fixup: make linter happy and avoid lll
florianl Feb 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions reporter/internal/pdata/generate.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,11 @@ func (p *Pdata) Generate(events map[libpf.Origin]samples.KeyToEventMapping) ppro
sp := rp.ScopeProfiles().AppendEmpty()
for _, origin := range []libpf.Origin{support.TraceOriginSampling,
support.TraceOriginOffCPU} {
if len(events[origin]) == 0 {
// Do not append empty profiles, if there
// is not profiling data for this origin.
continue
}
prof := sp.Profiles().AppendEmpty()
prof.SetProfileID(pprofile.ProfileID(mkProfileID()))
p.setProfile(origin, events[origin], prof)
Expand Down
8 changes: 7 additions & 1 deletion reporter/internal/pdata/generate_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -257,9 +257,15 @@ func TestFunctionTableOrder(t *testing.T) {
d.Executables.Add(k, v)
}
res := d.Generate(tt.events)
expectedProfiles := len(tt.events)
require.Equal(t, 1, res.ResourceProfiles().Len())
require.Equal(t, 1, res.ResourceProfiles().At(0).ScopeProfiles().Len())
require.Equal(t, 2, res.ResourceProfiles().At(0).ScopeProfiles().At(0).Profiles().Len())
require.Equal(t, expectedProfiles, res.ResourceProfiles().
At(0).ScopeProfiles().
At(0).Profiles().Len())
if expectedProfiles == 0 {
return
}
p := res.ResourceProfiles().At(0).ScopeProfiles().At(0).Profiles().At(0)
require.Equal(t, len(tt.wantFunctionTable), p.FunctionTable().Len())
for i := 0; i < p.FunctionTable().Len(); i++ {
Expand Down