Skip to content

processmanager: Fix process exit regression (#337) #338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rockdaboot merged 2 commits into from
Feb 5, 2025
Merged

processmanager: Fix process exit regression (#337) #338

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7f3bafe
processmanager: Fix process exit regression (#337)
christos68k Feb 3, 2025
31fc964
Simplify further
christos68k Feb 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 8 additions & 9 deletions processmanager/processinfo.go
View file
Open in desktop
Comment thread
christos68k marked this conversation as resolved.
Original file line number Diff line number Diff line change
Expand Up @@ -530,15 +530,14 @@ func (pm *ProcessManager) processPIDExit(pid libpf.PID) {
log.Debugf("Skip process exit handling for unknown PID %d", pid)
return
}
if pm.interpreterTracerEnabled && len(pm.interpreters[pid]) > 0 {
// ProcessPIDExit may be called multiple times in short succession
// for the same PID, don't update exitKTime if we've previously recorded it.
if _, pidExitProcessed := pm.exitEvents[pid]; !pidExitProcessed {
pm.exitEvents[pid] = exitKTime
} else {
log.Debugf("Skip duplicate process exit handling for PID %d", pid)
return
}

// ProcessPIDExit may be called multiple times in short succession
// for the same PID, don't update exitKTime if we've previously recorded it.
if _, pidExitProcessed := pm.exitEvents[pid]; !pidExitProcessed {
pm.exitEvents[pid] = exitKTime
} else {
log.Debugf("Skip duplicate process exit handling for PID %d", pid)
return
}

// Delete all entries we have for this particular PID from pid_page_to_mapping_info.
Expand Down