Add PID as an attribute in each sample #212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christos68k
reviewed
Oct 28, 2024
|
Hi @bhavnajindal, can you please also sign the CLA? |
Hi, I have initiated the process of signing the corporate CLA through my organization - IBM. Awaiting approval from the CLA manager. |
|
Note that we're about to introduce a new collector reporter, that will ultimately replace this OTLP one. |
|
@dmathieu Is there a feature branch available for the new collector reporter. |
florianl
reviewed
Nov 1, 2024
florianl
reviewed
Nov 1, 2024
florianl
reviewed
Nov 4, 2024
florianl
reviewed
Nov 5, 2024
|
@bhavnajindal Just in case you prefer generics, there is a solution (feel free to use). It still requires a type switch, but you don't need to return error from |
|
@rockdaboot Thank you for your solution. I had almost reached the same solution yesterday but my in-experience with go kept me from fully realizing the solution. I learnt a good deal from your code. Thanks again. |
florianl
approved these changes
Nov 5, 2024
rockdaboot
reviewed
Nov 5, 2024
christos68k
approved these changes
Nov 6, 2024
Merged
florianl
added a commit
that referenced
this pull request
Nov 8, 2024
PR #212 changed the behaviour of addProfileAttributes(). Before adding an attribute the length of the string was checked - see https://github.com/open-telemetry/opentelemetry-ebpf-profiler/blob/0c58efd41280bce80cca9804896c76874d383b35/reporter/otlp_reporter.go#L747-L749 This returns to the original behaivour, where string attributes with no values are not added. Signed-off-by: Florian Lehner <[email protected]>
bhavnajindal
added a commit
to instana/opentelemetry-ebpf-profiler
that referenced
this pull request
Nov 14, 2024
ltrk2
added a commit
to instana/opentelemetry-ebpf-profiler
that referenced
this pull request
Dec 4, 2024
* Fix unwinding at syscall on aarch64 (open-telemetry#218) * Add PID as an attribute in each sample (open-telemetry#212) * ebpf: increase number of stack delta buckets (open-telemetry#231) Signed-off-by: Florian Lehner <[email protected]> * reporter: use htlhash attribute for profiling specific hash (open-telemetry#236) Signed-off-by: Florian Lehner <[email protected]> * reporter: drop fifo (open-telemetry#239) Signed-off-by: Florian Lehner <[email protected]> * Drop more unused code (open-telemetry#240) * reporter: do not add empty attributes (open-telemetry#233) Signed-off-by: Florian Lehner <[email protected]> * controller: fix reporter interval mix up with monitor interval (open-telemetry#242) * Extract reporter runloop (open-telemetry#228) Co-authored-by: Christos Kalkanis <[email protected]> * Extract lookupcgroupv2 out of the otlp reporter (open-telemetry#227) * Add CPU id to trace and trace metadata (open-telemetry#249) * reporter: don't expire actively used executables (open-telemetry#247) * Remove legacy code from libpf.UnixTime64 (open-telemetry#252) * Turn kernel module file parsing errors into warnings (open-telemetry#255) Co-authored-by: Florian Lehner <[email protected]> * readatbuf: add missing check when reading from tail chunk (open-telemetry#259) * metrics: Don't send counters with 0 values (open-telemetry#246) --------- Signed-off-by: Florian Lehner <[email protected]> Co-authored-by: umanwizard <[email protected]> Co-authored-by: Bhavna Jindal <[email protected]> Co-authored-by: Florian Lehner <[email protected]> Co-authored-by: Tim Rühsen <[email protected]> Co-authored-by: Nayef Ghattas <[email protected]> Co-authored-by: Damien Mathieu <[email protected]> Co-authored-by: Christos Kalkanis <[email protected]> Co-authored-by: Tommy Reilly <[email protected]> Co-authored-by: Joel Höner <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
This PR aims to add process Id as an attribute for each sample. This would be an addition to other attributes such as containerId, threadName etc. being sent currently.
Why:
Tools/services consuming the profiles sent by opentelemetry-ebpf-profiler could utilize the PID as an identifier for a process in their software/implementations.