Skip to content

CI: fix collector test#1354

Merged
christos68k merged 4 commits into
open-telemetry:mainfrom
florianl:collector-tests-fails
Apr 14, 2026
Merged

CI: fix collector test#1354
christos68k merged 4 commits into
open-telemetry:mainfrom
florianl:collector-tests-fails

Conversation

@florianl
Copy link
Copy Markdown
Member

These replace statements are necessary as golangci-lint introduces dependencies, that conflict with eBPF profiler and OTel collector.

$ go mod graph -modfile=internal/tools/go.mod | grep "google.golang.org/genproto"
github.com/securego/gosec/v2@v2.24.8-0.20260309165252-619ce2117e08 google.golang.org/genproto/googleapis/rpc@v0.0.0-20250818200422-3122310a409c
$ go mod graph -modfile=internal/tools/go.mod | grep github.com/securego/gosec/v2
github.com/open-telemetry/opentelemetry-ebpf-profiler/internal/tools github.com/securego/gosec/v2@v2.24.8-0.20260309165252-619ce2117e08
github.com/golangci/golangci-lint/v2@v2.11.4 github.com/securego/gosec/v2@v2.24.8-0.20260309165252-619ce2117e08

These replace statements are necessary as golangci-lint introduces dependencies, that conflict with eBPF profiler and OTel collector.

```
$ go mod graph -modfile=internal/tools/go.mod | grep "google.golang.org/genproto"
github.com/securego/gosec/v2@v2.24.8-0.20260309165252-619ce2117e08 google.golang.org/genproto/googleapis/rpc@v0.0.0-20250818200422-3122310a409c
$ go mod graph -modfile=internal/tools/go.mod | grep github.com/securego/gosec/v2
github.com/open-telemetry/opentelemetry-ebpf-profiler/internal/tools github.com/securego/gosec/v2@v2.24.8-0.20260309165252-619ce2117e08
github.com/golangci/golangci-lint/v2@v2.11.4 github.com/securego/gosec/v2@v2.24.8-0.20260309165252-619ce2117e08
```

Signed-off-by: Florian Lehner <florian.lehner@elastic.co>
@florianl florianl requested review from a team as code owners April 14, 2026 08:18
Signed-off-by: Florian Lehner <florian.lehner@elastic.co>
Signed-off-by: Florian Lehner <florian.lehner@elastic.co>
Signed-off-by: Florian Lehner <florian.lehner@elastic.co>
@dmathieu
Copy link
Copy Markdown
Member

Wouldn't it be better to upgrade those dependencies on our end?

@florianl
Copy link
Copy Markdown
Member Author

Wouldn't it be better to upgrade those dependencies on our end?

The dependency google.golang.org/genproto is introduced in eBPF profiler by OTel collector with a fairly recent version v0.0.0-20260226221140-a57be14db171:

$ go mod why -m google.golang.org/genproto/googleapis/rpc
# google.golang.org/genproto/googleapis/rpc
go.opentelemetry.io/ebpf-profiler/reporter
go.opentelemetry.io/collector/pdata/pprofile/pprofileotlp
google.golang.org/grpc/status
google.golang.org/genproto/googleapis/rpc/status

On the tools side, google.golang.org/genproto is introduced via github.com/golangci/golangci-lint/v2@v2.11.4 (the most recent version which is currently 3 weeks old) and its dependency on github.com/securego/gosec/v2 (also only a few weeks old) which builds on fairly old version (v0.0.0-20250818200422-3122310a409c) of google.golang.org/genproto.

@christos68k christos68k merged commit 9aad0a1 into open-telemetry:main Apr 14, 2026
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants