Skip to content

metrics: skip entries with empty field in Start()#1303

Merged
christos68k merged 1 commit into
open-telemetry:mainfrom
rogercoll:fix_init_metric
Mar 31, 2026
Merged

metrics: skip entries with empty field in Start()#1303
christos68k merged 1 commit into
open-telemetry:mainfrom
rogercoll:fix_init_metric

Conversation

@rogercoll
Copy link
Copy Markdown
Contributor

@rogercoll rogercoll commented Mar 31, 2026

The id 0 "Invalid" sentinel in metrics.json has an intentionally empty field and is not marked obsolete (IDInvalid is used at runtime for bounds checking).

$ make otelcol-ebpf-profiler
2026-03-31T17:08:26.805+0800	error	Creating Int64Counter: invalid instrument name: : is empty	{"resource": {"service.instance.id": "2345a511-2883-4318-9742-51c20f09218f", "se     rvice.name": "otelcol-ebpf-profiler", "service.version": "dev"}, "otelcol.component.id": "profiling", "otelcol.component.kind": "receiver", "otelcol.signal": "profiles"}
go.opentelemetry.io/ebpf-profiler/internal/log.Errorf
	/home/neck/Documents/github/rogercoll/opentelemetry-ebpf-profiler/internal/log/logging.go:69
go.opentelemetry.io/ebpf-profiler/metrics.Start
	/home/neck/Documents/github/rogercoll/opentelemetry-ebpf-profiler/metrics/metrics.go:62
go.opentelemetry.io/ebpf-profiler/collector/internal.NewController
	/home/neck/Documents/github/rogercoll/opentelemetry-ebpf-profiler/collector/internal/controller.go:62
go.opentelemetry.io/ebpf-profiler/collector.NewFactory.BuildProfilesReceiver.func1
	/home/neck/Documents/github/rogercoll/opentelemetry-ebpf-profiler/collector/factory_linux.go:48
go.opentelemetry.io/collector/receiver/xreceiver.(*factory).CreateProfiles
	/home/neck/.go/pkg/mod/go.opentelemetry.io/collector/receiver/xreceiver@v0.148.0/receiver.go:76

The id 0 "Invalid" sentinel in metrics.json has an intentionally empty
field and is not marked obsolete (IDInvalid is used at runtime for
bounds checking).
@rogercoll rogercoll requested review from a team as code owners March 31, 2026 09:25
Copy link
Copy Markdown
Member

@florianl florianl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch

@christos68k christos68k merged commit 30f023a into open-telemetry:main Mar 31, 2026
32 checks passed
gnurizen pushed a commit to parca-dev/opentelemetry-ebpf-profiler that referenced this pull request May 4, 2026
gnurizen pushed a commit to parca-dev/opentelemetry-ebpf-profiler that referenced this pull request May 5, 2026
gnurizen pushed a commit to parca-dev/opentelemetry-ebpf-profiler that referenced this pull request May 12, 2026
gnurizen pushed a commit to parca-dev/opentelemetry-ebpf-profiler that referenced this pull request May 19, 2026
gnurizen pushed a commit to parca-dev/opentelemetry-ebpf-profiler that referenced this pull request May 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants