Update CONTRIBUTING with more clear review feedback handling#1296
Merged
Conversation
rogercoll
approved these changes
Mar 30, 2026
dmathieu
approved these changes
Apr 1, 2026
florianl
reviewed
Apr 1, 2026
|
|
||
| You can pull the GitHub-generated commits (after you've accepted a suggestion) | ||
| into your local repository by executing: | ||
|
|
Member
There was a problem hiding this comment.
To me this guide promotes reviewers to ask for a rephrase of a comment to get credit on the whole PR.
Reviewers, that comment and point out structual issues and request such changes will not get credit for it.
Member
Author
There was a problem hiding this comment.
The credit will come automatically from GH if the author accepts a suggestion. I'm not opposed to having an additional mechanism for credit related to deeper structural changes that are also accepted, that sounds good to me.
We should open another PR for that.
This was referenced Apr 1, 2026
gnurizen
pushed a commit
to parca-dev/opentelemetry-ebpf-profiler
that referenced
this pull request
May 4, 2026
gnurizen
pushed a commit
to parca-dev/opentelemetry-ebpf-profiler
that referenced
this pull request
May 5, 2026
gnurizen
pushed a commit
to parca-dev/opentelemetry-ebpf-profiler
that referenced
this pull request
May 12, 2026
This was referenced May 15, 2026
gnurizen
pushed a commit
to parca-dev/opentelemetry-ebpf-profiler
that referenced
this pull request
May 19, 2026
gnurizen
pushed a commit
to parca-dev/opentelemetry-ebpf-profiler
that referenced
this pull request
May 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a short paragraph outlining how to handle review feedback suggestions.