Skip to content

Log errors in newFrameMapping as promised #1285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
christos68k merged 1 commit into from
Apr 9, 2026
Merged

Log errors in newFrameMapping as promised #1285

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion processmanager/processinfo.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -349,14 +349,16 @@ func (pm *ProcessManager) newFrameMapping(pr process.Process, m *process.Mapping

elfSpaceVA, ok := info.addressMapper.FileOffsetToVirtualAddress(m.FileOffset)
if !ok {
log.Debugf("Failed to map file offset of PID %d, file %s, offset %d",
log.Warnf("Failed to map file offset of PID %d, file %s, offset %d",
pr.PID(), m.Path, m.FileOffset)
return libpf.FrameMapping{}, errInvalidVirtualAddress
}

fileID := host.FileIDFromLibpf(info.mappingFile.Value().FileID)
ei, err := pm.eim.AddOrIncRef(fileID, elfRef)
if err != nil {
log.Errorf("Failed to load executable info for PID %d file %v (fileID %s): %v",
pr.PID(), m.Path, fileID.StringNoQuotes(), err)
return libpf.FrameMapping{}, err
}

Expand Down
Loading