Skip to content

feat: jdk 26 support#1240

Merged
christos68k merged 10 commits into
open-telemetry:mainfrom
wehzzz:fix-jdk-26-support
Mar 12, 2026
Merged

feat: jdk 26 support#1240
christos68k merged 10 commits into
open-telemetry:mainfrom
wehzzz:fix-jdk-26-support

Conversation

@wehzzz
Copy link
Copy Markdown
Contributor

@wehzzz wehzzz commented Mar 10, 2026

What does this PR do?

Related issue: #1239

Adds JDK 26 support to the HotSpot JVM interpreter in the eBPF profiler. It handles breaking changes in the JDK 26 nmethod VM struct by adding new field mappings and adjusting immutable data size calculation to account for the new ref count trailer.

Key changes in interpreter/hotspot/:

  • data.go: Added ImmutableDataRefCountOff field (JDK 26+), added _deopt_handler_entry_offset as an alias for DeoptimizeOffset.
  • instance.go: When _immutable_data_ref_count_offset is present, use it to cap the immutable data region size.
  • hotspot.go: Documented JDK 26 changes in the version history comment block.

@wehzzz wehzzz mentioned this pull request Mar 10, 2026
@fabled
Copy link
Copy Markdown
Contributor

fabled commented Mar 10, 2026

Thanks! Took a quick glance and looks good! What is missing to remove draft status?

Also, could you add one or two core dump test cases?

@wehzzz
Copy link
Copy Markdown
Contributor Author

wehzzz commented Mar 10, 2026

Thanks! Took a quick glance and looks good! What is missing to remove draft status?

Also, could you add one or two core dump test cases?

Thanks for the feedback !

I just wanted to run some more extensive tests in a real environment to make sure there are no regressions. I'll look into adding the coredump tests ASAP!

@wehzzz
Copy link
Copy Markdown
Contributor Author

wehzzz commented Mar 12, 2026

I have included coredump tests. The relevant coredump files can be accessed via the link below.
https://drive.google.com/file/d/1DahpvR3ciI_zTP5ua19LG5Tr8EBHHeJI/view

@florianl
Copy link
Copy Markdown
Member

florianl commented Mar 12, 2026

I have fetched the coredumps, uploaded it to the S3 storage and retriggered tests. Will you mark the PR as ready for review?

@wehzzz wehzzz marked this pull request as ready for review March 12, 2026 08:37
@wehzzz wehzzz requested review from a team as code owners March 12, 2026 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants