Update codespell configuration to reduce false positives#1136
Conversation
b86dd34 to
dc528de
Compare
|
Hi @gyanranjanpanda can you update your PR to take the (just merged) #1119 into account? Thanks! |
Configure codespell to skip common code patterns and focus on checking natural language text in comments and documentation. This addresses issue open-telemetry#1108 where codespell was flooding output with false positives on variable names and code constructs. The ignore-regex pattern now skips: - camelCase identifiers - snake_case identifiers - hexadecimal numbers - import/package/use/include statements Fixes open-telemetry#1108
dc528de to
fbf880b
Compare
|
Thanks @christos68k! I've rebased on the latest main to include the changes from #1119. I resolved the conflict in Required checks should be running now. |
44ae37b to
b94e9c5
Compare
|
hi @christos68k ,@rogercoll |
|
|
||
| - in every stack trace, all[^all] frames except for the last one will always be a | ||
| return addresses thats follow a call | ||
| return addresses that's follow a call |
There was a problem hiding this comment.
| return addresses that's follow a call | |
| return address that follows a call |
There was a problem hiding this comment.
Thank you for catching that! You're absolutely right - I've updated line 110 to fix the grammar. The change has been pushed.
Please let me know if there's anything else that needs adjustment!
There was a problem hiding this comment.
It's still not correct, see my suggestion
There was a problem hiding this comment.
i did it what u want if i have to do any thing pls let me know
There was a problem hiding this comment.
For future reference, I think it's just easier to accept a reviewer's suggestion in the GH UI instead of reimplementing it. It saves time (as the reviewer can see that the suggestion was implemented exactly as given and doesn't have to check again) and avoids errors like the one that took place here.
Fixes #1108
Summary
This PR updates the codespell configuration to reduce false positives by adding an
ignore-regexpattern that skips common code constructs while still checking natural language text in comments and documentation.Changes
ignore-regexto.codespellrcto skip:myVariable,someFunction)my_variable,some_function)0x1234)Testing
The existing CI workflow will verify that codespell runs successfully with the new configuration. The updated regex pattern significantly reduces false positives on code elements while maintaining spell checking for comments and documentation.