Skip to content

Fix unwinding on arm64 kernel v6.18-rc1 and newer#1094

Merged
christos68k merged 2 commits into
open-telemetry:mainfrom
fabled:tt-fix-arm64-unwind
Jan 20, 2026
Merged

Fix unwinding on arm64 kernel v6.18-rc1 and newer#1094
christos68k merged 2 commits into
open-telemetry:mainfrom
fabled:tt-fix-arm64-unwind

Conversation

@fabled
Copy link
Copy Markdown
Contributor

@fabled fabled commented Jan 20, 2026

Some fields of the arm64 pt_regs were removed recently (the last two fields, see commit torvalds/linux@ee776d6).

This caused attempt to read beyond the stack page. Let's remove the fields we don't need to reduce data read, and similar issues if additional kernel internals are removed from this struct. But keep the struct size multiple of 8 for fast memory copy.

fixes #1054

@fabled fabled force-pushed the tt-fix-arm64-unwind branch from ad08be3 to a500a72 Compare January 20, 2026 08:17
@fabled fabled marked this pull request as ready for review January 20, 2026 13:54
@fabled fabled requested review from a team as code owners January 20, 2026 13:54
@christos68k christos68k merged commit 7f9dd96 into open-telemetry:main Jan 20, 2026
29 checks passed
@bobrik
Copy link
Copy Markdown
Contributor

bobrik commented Jan 22, 2026

Is there a way to detect this sort of a regression with integration checks that would run the latest kernel?

@fabled
Copy link
Copy Markdown
Contributor Author

fabled commented Jan 22, 2026

Is there a way to detect this sort of a regression with integration checks that would run the latest kernel?

I believe this would have been caught by the integration tests if new enough kernel was included in the kernel versions to test matrix. The latest kernel it does currently is 6.16. They way the test matrix is setup, adding new kernels requires a manual update to the github ci/cd yml.

@florianl florianl mentioned this pull request Jan 22, 2026
@florianl
Copy link
Copy Markdown
Member

Just created #1103 to add more recent kernels to our CI. For background information, there was an issue that prevented earlier use of new kernels - see cilium/ci-kernels#84.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cannot unwind past syscall boundary on aarch64

4 participants