fix(collector): propagate context to reportProfile for graceful shutdown#1050
Merged
christos68k merged 4 commits intoJan 8, 2026
Merged
Conversation
florianl
approved these changes
Jan 8, 2026
christos68k
approved these changes
Jan 8, 2026
Co-authored-by: Christos Kalkanis <christos.kalkanis@elastic.co>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, the collector's run loop triggered
reportProfileusingcontext.Background(). This detached the reporting process from the profiler's lifecycle context.If the profiler/collector was stopped (cancelled) while a report was being processed, the underlying consumer would ignore the cancellation signal and continue running. This could lead to hanging goroutines or delays during application shutdown.
Updated the test to explicitly verify that the consumer respects the context cancellation.