Skip to content

symblib: support Go 1.26#1035

Merged
fabled merged 2 commits into
open-telemetry:mainfrom
florianl:symblib-go126
Jan 1, 2026
Merged

symblib: support Go 1.26#1035
fabled merged 2 commits into
open-telemetry:mainfrom
florianl:symblib-go126

Conversation

@florianl
Copy link
Copy Markdown
Member

Similar to #1032 fall back to use .text address if the field text_start is 0.

Similar to open-telemetry#1032 fall back to use .text address if the field text_start is 0.

Signed-off-by: Florian Lehner <florian.lehner@elastic.co>
@florianl florianl requested review from a team as code owners December 23, 2025 07:23
@florianl
Copy link
Copy Markdown
Member Author

florianl commented Dec 23, 2025

CI will be fixed with #1036.

An alternative approach to #1036 would be updating the Rust version. Currently, the project uses 1.77.2. The dependency requires 1.82 and at the moment the current stable version is 1.92.

I'm not sure, why this issue was not detected by CI earlier.

Copy link
Copy Markdown
Member

@athre0z athre0z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, ty! For the CI issue, I'd recommend to just update the Rust toolchain.

I'm not sure, why this issue was not detected by CI earlier.

That's weird indeed -- would've expected it to show up during e.g. #1008. 🤔

@florianl
Copy link
Copy Markdown
Member Author

florianl commented Dec 23, 2025

[..] I'd recommend to just update the Rust toolchain.

I agree with that. #1036 is just a fast way forward to unblock this PR.
Updating the Rust toolchain will be a multiple step process - update Cargo, update build Dockerfile, use new Dockerfile and maybe other steps along the way.

Opened #1038 to update the toolchain.

@fabled fabled merged commit 358c23c into open-telemetry:main Jan 1, 2026
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants