Skip to content

gopclntab: Use address of .text section for Go 1.26 #1032

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
christos68k merged 3 commits into from
Dec 22, 2025
Merged

gopclntab: Use address of .text section for Go 1.26 #1032

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3ee0fcf
gopclntab: Use address of .text section for Go 1.26
florianl Dec 22, 2025
1c0668f
apply feedback
florianl Dec 22, 2025
092e985
apply feedback
florianl Dec 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions nativeunwind/elfunwindinfo/elfgopclntab.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -468,6 +468,20 @@ func NewGopclntab(ef *pfelf.File) (*Gopclntab, error) {
g.functab = data[hdr118.pclnOffset:]
g.funcdata = g.functab
g.textStart = hdr118.textStart
if g.textStart == 0 {
// Starting with Go 1.26 the field textStart is set to 0 but moduledata.text
// which contains the same value is unaffected.
// The following logic assumes that .text matches moduledata.text
// which might not always be true (in which case we need to switch to moduledata.text
// which can be found through runtime.firstmoduledata).
//
//nolint:lll
// See https://github.com/golang/go/commit/0e1bd8b5f17e337df0ffb57af03419b96c695fe4
if sec := ef.Section(".text"); sec != nil {
g.textStart = uintptr(sec.Addr)
break
}
}
// With the change of the type of the first field of _func in Go 1.18, this
// value is now hard coded.
//
Expand Down