Skip to content

Add sdk language to span metrics - #908

Merged
grcevski merged 1 commit into
open-telemetry:mainfrom
grcevski:span_telemetry_sdk_name
Nov 21, 2025
Merged

Add sdk language to span metrics#908
grcevski merged 1 commit into
open-telemetry:mainfrom
grcevski:span_telemetry_sdk_name

Conversation

@grcevski

Copy link
Copy Markdown
Contributor

The program language is low cardinality and it's quite useful to be part of span metrics, avoiding expensive joins with target_info.

@grcevski
grcevski requested a review from a team as a code owner November 20, 2025 20:19
@codecov

codecov Bot commented Nov 20, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 66.66667% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 55.12%. Comparing base (7e3c547) to head (57b2da3).
⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
pkg/appolly/app/request/span_getters.go 0.00% 3 Missing ⚠️
pkg/export/prom/prom.go 0.00% 2 Missing ⚠️
pkg/export/otel/metrics.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #908      +/-   ##
==========================================
- Coverage   55.14%   55.12%   -0.02%     
==========================================
  Files         253      253              
  Lines       21719    21725       +6     
==========================================
- Hits        11976    11975       -1     
- Misses       8920     8926       +6     
- Partials      823      824       +1     
Flag Coverage Δ
integration-test 23.26% <66.66%> (-0.03%) ⬇️
integration-test-arm 0.00% <0.00%> (ø)
integration-test-vm-${ARCH}-${KERNEL_VERSION} 0.00% <0.00%> (?)
k8s-integration-test 2.73% <0.00%> (-0.01%) ⬇️
oats-test 0.00% <0.00%> (ø)
unittests 46.23% <66.66%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@marctc marctc left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@grcevski
grcevski merged commit 458d524 into open-telemetry:main Nov 21, 2025
60 of 61 checks passed
@grcevski
grcevski deleted the span_telemetry_sdk_name branch November 21, 2025 14:25
@MrAlias MrAlias added this to the v0.3.0 milestone Dec 3, 2025
@MrAlias MrAlias mentioned this pull request Dec 3, 2025
marctc pushed a commit to grafana/opentelemetry-ebpf-instrumentation that referenced this pull request Dec 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants