Low-cardinality route from path mode - #882
Merged
grcevski merged 14 commits intoNov 13, 2025
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #882 +/- ##
==========================================
+ Coverage 55.15% 55.29% +0.14%
==========================================
Files 251 252 +1
Lines 21481 21593 +112
==========================================
+ Hits 11847 11940 +93
- Misses 8818 8831 +13
- Partials 816 822 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
rafaelroquetto
approved these changes
Nov 13, 2025
Merged
marctc
pushed a commit
to grafana/opentelemetry-ebpf-instrumentation
that referenced
this pull request
Dec 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OBI does only Java route harvesting at the moment, and while we are expanding that support, there may always be the need to derive the OTel compliant route from the URL path. At the moment, the default mode in OBI is the clustering approach, where we detect IDs and gibberish words.
The clustering (gibberish) detection can be easily defeated via Github like URL patterns. For example, none of these paths are gibberish and will produce a high-cardinality derived route:
With this PR I'm introducing a second level route collapsing mechanism, which aggregates by service the high cardinality routes using a
trie. We have a new config option which is the allowed cardinality per level and once the paths grow beyond the allowed level, the trie node is collapsed into thewildcard.