allow printing out spans in OTEL format using debugexporter - #881
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #881 +/- ##
==========================================
- Coverage 55.15% 55.13% -0.02%
==========================================
Files 251 251
Lines 21481 21492 +11
==========================================
+ Hits 11847 11849 +2
- Misses 8818 8828 +10
+ Partials 816 815 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
grcevski
left a comment
There was a problem hiding this comment.
This is great! I would just suggest to maybe call the exporter "console" instead of debug, this is how other OTEL SDKs would do it.
It's a great idea!
|
My take on things :)
Detailed as you have it is perfect.
It's fine to be one or the other, that's how the SDKs do it. You can define |
since we are using the exporter packages from the collector we are using the debugexporter. is there a reason we are using collector exporters and not sdk exporters? |
in SDKs you can also manage multiple exporters as part of your traceprovider config, i think i can keep it like that as a single one for now, we also had a talk regarding how we can make sure the OBI config conforms to more standard sdk configs, but that can be done in the future |
Oh I see what you mean, yeah the collector calls it "debug/traces", I think that works then. I understand the comment about two of them at the same time now too, you mean something like configuring the OTel collector exporters like: |
This allows us to print out the spans in their "final" OTEL compliant form instead of our intermediate representation, using the collector debugexporter, this can be very good when debugging the full path from OBI -> OTEL, and also for quick demos :)
still have 2 questions im wondering about
basicdoesn't tell us much but the number of spansTraces {"resource spans": 1, "spans": 3}normalgives us all the information in a compact viewdetailedgives us the full view with all attributes expandedi went with
detailedfor now to see everything, but if you think its too much lmk, we can also make it configurable.2. should we allow this debugexporter to be used in combination with other exporters? currently its either debug or something like otlp, but not both at the same time.
we can support this but we need to implement some combined exporter or send a slice of exporters to the handling function.