Add support for Opensearch client span - #871
Merged
Merged
Conversation
pinoOgni
commented
Nov 6, 2025
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #871 +/- ##
==========================================
- Coverage 55.15% 55.10% -0.05%
==========================================
Files 251 251
Lines 21481 21494 +13
==========================================
- Hits 11847 11845 -2
- Misses 8818 8832 +14
- Partials 816 817 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mmat11
requested changes
Nov 7, 2025
mmat11
left a comment
mmat11
left a comment
Contributor
There was a problem hiding this comment.
left some comments, CI is failing, probably a rebase is needed
pinoOgni
force-pushed
the
pgn/opensearch
branch
from
November 7, 2025 15:02
1a3338d to
3ae6df6
Compare
pinoOgni
marked this pull request as ready for review
November 7, 2025 15:18
mmat11
approved these changes
Nov 7, 2025
mmat11
left a comment
mmat11
left a comment
Contributor
There was a problem hiding this comment.
left a couple more comments, lgtm!
pinoOgni
force-pushed
the
pgn/opensearch
branch
2 times, most recently
from
November 7, 2025 16:44
4aee72f to
fb4aaab
Compare
Contributor
|
Can we add a row for opensearch in devdocs/features.md? |
Contributor
Author
Oh, sure! |
grcevski
approved these changes
Nov 10, 2025
grcevski
left a comment
grcevski
left a comment
Contributor
There was a problem hiding this comment.
LGTM! Thanks for adding this! I'm good to merge, we can maybe just address Nimrod's last comment about 3.0.0+.
Signed-off-by: Giuseppe Ognibene <giuseppe.ognibene@coralogix.com>
Signed-off-by: Giuseppe Ognibene <giuseppe.ognibene@coralogix.com>
pinoOgni
force-pushed
the
pgn/opensearch
branch
from
November 11, 2025 09:21
fdfa55d to
64930c1
Compare
Contributor
Author
Done! :) |
Merged
marctc
pushed a commit
to grafana/opentelemetry-ebpf-instrumentation
that referenced
this pull request
Dec 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces support for Opensearch client span, continuing the work already done for Elasticsearch (#801 and #853)
Opensearch doesn't have an opentelemetry semconv, so I reused Elasticsearch's with the only difference being the
db.system.namefield.Moreoveor, to avoid duplicating code, I rewrote the tests and the python testserver to make it generic.