Remove check-ebpf-ver-synced make target#1694
Conversation
This target was used to ensure the github.com/cilium/ebpf package version was the same in the generator as that used locally. This was made unneeded in open-telemetry#1290.
Codecov Report✅ All modified and coverable lines are covered by tests.
Additional details and impacted files@@ Coverage Diff @@
## main #1694 +/- ##
===========================================
- Coverage 44.48% 18.84% -25.65%
===========================================
Files 337 264 -73
Lines 36472 30774 -5698
===========================================
- Hits 16225 5798 -10427
- Misses 19225 24287 +5062
+ Partials 1022 689 -333
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| package bpfcore // import "go.opentelemetry.io/obi/bpf/bpfcore" | ||
|
|
||
| // Store loader version here in order to run the full test suite on upgrades. | ||
| // github.com/cilium/ebpf v0.20.0 |
There was a problem hiding this comment.
this is used to trigger a full CI run when the library is bumped
There was a problem hiding this comment.
Pull request overview
Removes the now-unneeded check-ebpf-ver-synced Make target and its CI invocation, aligning version-sync validation with the newer Makefile-based generation flow introduced in #1290.
Changes:
- Removed
CILIUM_EBPF_VER/CILIUM_EBPF_PKGvars and thecheck-ebpf-ver-syncedtarget from the Makefile. - Deleted the ebpf-version comment from
bpf/bpfcore/placeholder.go. - Dropped
check-ebpf-ver-syncedfrom the PR workflow checks.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| Makefile | Removes the version-sync check target and related variables. |
| bpf/bpfcore/placeholder.go | Removes the embedded ebpf version comment from the placeholder file. |
| .github/workflows/pull_request.yml | Removes the CI step invocation of the deleted Make target. |
| @@ -4,6 +4,3 @@ | |||
| //go:build obi_bpf | |||
|
|
|||
| package bpfcore // import "go.opentelemetry.io/obi/bpf/bpfcore" | |||
There was a problem hiding this comment.
This change updates the source file under bpf/bpfcore/, but the repo also commits a mirrored copy under NOTICES/ that is refreshed by make notices-update (see Makefile BPF_FILES/TARGET_BPF_FILES copy rule). As-is, CI’s make notices-update will modify NOTICES/bpf/bpfcore/placeholder.go and then check-clean-work-tree will fail. Please run make notices-update and commit the resulting NOTICES update (or update the NOTICES copy manually).
This target was used to ensure the github.com/cilium/ebpf package version was the same in the generator as that used locally. This was made unneeded in #1290.
Blocking #1624