Skip to content

largebuffers: Add cursor integer helpers#1476

Merged
MrAlias merged 2 commits into
open-telemetry:mainfrom
rafaelroquetto:lb_helpers
Mar 5, 2026
Merged

largebuffers: Add cursor integer helpers#1476
MrAlias merged 2 commits into
open-telemetry:mainfrom
rafaelroquetto:lb_helpers

Conversation

@rafaelroquetto
Copy link
Copy Markdown
Contributor

Add cursor equivalents of the integer scalar helpers. These will be used to simplify the parsing code.

Checklist

@rafaelroquetto rafaelroquetto requested a review from a team as a code owner March 5, 2026 16:52
@rafaelroquetto rafaelroquetto requested a review from Copilot March 5, 2026 16:52
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@rafaelroquetto rafaelroquetto requested a review from Copilot March 5, 2026 17:16
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@rafaelroquetto
Copy link
Copy Markdown
Contributor Author

DO NOT MERGE until actions / tests are working again and have passed

@rafaelroquetto rafaelroquetto requested a review from Copilot March 5, 2026 17:50
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

Comment thread pkg/internal/largebuf/large_buffer_test.go Outdated
Comment thread pkg/internal/largebuf/large_buffer_test.go Outdated
Comment thread pkg/internal/largebuf/large_buffer_test.go Outdated
Comment thread pkg/internal/largebuf/large_buffer.go
@rafaelroquetto rafaelroquetto requested a review from Copilot March 5, 2026 18:22
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 5, 2026

Codecov Report

❌ Patch coverage is 65.15152% with 23 lines in your changes missing coverage. Please review.
✅ Project coverage is 43.97%. Comparing base (2e2c5c6) to head (9457c4a).
⚠️ Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
pkg/internal/largebuf/large_buffer.go 65.15% 18 Missing and 5 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1476      +/-   ##
==========================================
+ Coverage   43.93%   43.97%   +0.03%     
==========================================
  Files         313      313              
  Lines       34265    34331      +66     
==========================================
+ Hits        15055    15096      +41     
- Misses      18232    18251      +19     
- Partials      978      984       +6     
Flag Coverage Δ
integration-test 21.46% <0.00%> (-0.25%) ⬇️
integration-test-arm 0.00% <0.00%> (ø)
integration-test-vm-x86_64-5.15.152 ?
integration-test-vm-x86_64-6.10.6 ?
k8s-integration-test 2.28% <0.00%> (-0.01%) ⬇️
oats-test 0.00% <0.00%> (ø)
unittests 44.99% <81.13%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@MrAlias MrAlias merged commit db77da0 into open-telemetry:main Mar 5, 2026
66 of 67 checks passed
@MrAlias MrAlias mentioned this pull request Mar 5, 2026
@MrAlias MrAlias added this to the v0.6.0 milestone Mar 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants