Initialize empty PROM_CONFIG_SUFFIX in test suite#1460
Merged
Conversation
Signed-off-by: Giuseppe Ognibene <giuseppe.ognibene@coralogix.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1460 +/- ##
==========================================
- Coverage 43.90% 43.90% -0.01%
==========================================
Files 313 313
Lines 34213 34213
==========================================
- Hits 15022 15020 -2
- Misses 18213 18214 +1
- Partials 978 979 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
rafaelroquetto
approved these changes
Mar 4, 2026
Contributor
rafaelroquetto
left a comment
There was a problem hiding this comment.
LGTM - out of curiosity, why is this necessary?
Contributor
Author
Some yaml files use PROM_CONFIG_SUFFIX without setting it. It's true that the value is an empty string, but it's more appropriate to set it explicitly, since the file name and therefore the Prometheus configuration changes based on the value. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR explicitly initializes
PROM_CONFIG_SUFFIXvariable within the test suite.