Skip to content

Initialize empty PROM_CONFIG_SUFFIX in test suite#1460

Merged
mmat11 merged 1 commit into
open-telemetry:mainfrom
coralogix:pgn/integration-tests
Mar 5, 2026
Merged

Initialize empty PROM_CONFIG_SUFFIX in test suite#1460
mmat11 merged 1 commit into
open-telemetry:mainfrom
coralogix:pgn/integration-tests

Conversation

@pinoOgni
Copy link
Copy Markdown
Contributor

@pinoOgni pinoOgni commented Mar 4, 2026

This PR explicitly initializes PROM_CONFIG_SUFFIX variable within the test suite.

Signed-off-by: Giuseppe Ognibene <giuseppe.ognibene@coralogix.com>
@pinoOgni pinoOgni requested a review from a team as a code owner March 4, 2026 19:06
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 4, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 43.90%. Comparing base (cc5693e) to head (ed99a6e).
⚠️ Report is 17 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1460      +/-   ##
==========================================
- Coverage   43.90%   43.90%   -0.01%     
==========================================
  Files         313      313              
  Lines       34213    34213              
==========================================
- Hits        15022    15020       -2     
- Misses      18213    18214       +1     
- Partials      978      979       +1     
Flag Coverage Δ
integration-test 21.48% <ø> (-0.27%) ⬇️
integration-test-arm 0.00% <ø> (ø)
integration-test-vm-x86_64-5.15.152 0.00% <ø> (ø)
integration-test-vm-x86_64-6.10.6 0.00% <ø> (ø)
k8s-integration-test 2.29% <ø> (ø)
oats-test 0.00% <ø> (ø)
unittests 44.89% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Contributor

@rafaelroquetto rafaelroquetto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - out of curiosity, why is this necessary?

@pinoOgni
Copy link
Copy Markdown
Contributor Author

pinoOgni commented Mar 4, 2026

LGTM - out of curiosity, why is this necessary?

Some yaml files use PROM_CONFIG_SUFFIX without setting it. It's true that the value is an empty string, but it's more appropriate to set it explicitly, since the file name and therefore the Prometheus configuration changes based on the value.

@mmat11 mmat11 merged commit ecaa387 into open-telemetry:main Mar 5, 2026
75 of 76 checks passed
@mmat11 mmat11 deleted the pgn/integration-tests branch March 5, 2026 17:05
@MrAlias MrAlias added this to the v0.6.0 milestone Mar 5, 2026
@MrAlias MrAlias mentioned this pull request Mar 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants