bpf: nodejs: set trace context in shared map via async callbacks#1454
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1454 +/- ##
=======================================
Coverage 43.89% 43.90%
=======================================
Files 313 313
Lines 34216 34216
=======================================
+ Hits 15019 15021 +2
+ Misses 18220 18217 -3
- Partials 977 978 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
rafaelroquetto
approved these changes
Mar 4, 2026
Contributor
rafaelroquetto
left a comment
rafaelroquetto
left a comment
There was a problem hiding this comment.
just a nit, feel free to disregard!
LGTM
Signed-off-by: Mattia Meleleo <mattia.meleleo@coralogix.com>
mmat11
force-pushed
the
matt/nodejs-shared
branch
from
531ed88 to
a78e4e5
Compare
mmat11
force-pushed
the
matt/nodejs-shared
branch
from
a78e4e5 to
fc7b23c
Compare
Contributor
|
Looks awesome! |
rafaelroquetto
approved these changes
Mar 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similarly to how done for the Go runtime, also add trace context for NodeJS runtime to the shared map
Checklist