ci: skip Docker Hub login when credentials unavailable#1439
Merged
Conversation
|
|
Add conditional step to skip Docker Hub login in test workflows when the DOCKER_TOKEN_EBPF_INSTRUMENTATION secret is not available. This prevents workflows from failing on fork PRs, Dependabot/Renovate PRs, and other contexts where repository secrets are not accessible, while preserving login for rate limit avoidance when credentials are available.
9a31c80 to
0e0e0e4
Compare
mmat11
approved these changes
Mar 3, 2026
MrAlias
approved these changes
Mar 3, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1439 +/- ##
==========================================
+ Coverage 43.74% 44.63% +0.89%
==========================================
Files 312 311 -1
Lines 33911 28681 -5230
==========================================
- Hits 14834 12803 -2031
+ Misses 18120 15103 -3017
+ Partials 957 775 -182
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Skip Docker Hub login in test workflows when credentials are not available. This prevents workflows from failing on fork PRs and Dependabot/Renovate PRs while preserving rate limit avoidance when credentials are present.
Changes
if: secrets.DOCKER_TOKEN_EBPF_INSTRUMENTATION != ''Checklist