Skip to content

ci: skip Docker Hub login when credentials unavailable#1439

Merged
MrAlias merged 1 commit into
open-telemetry:mainfrom
skl:skl/optional-docker-login
Mar 3, 2026
Merged

ci: skip Docker Hub login when credentials unavailable#1439
MrAlias merged 1 commit into
open-telemetry:mainfrom
skl:skl/optional-docker-login

Conversation

@skl
Copy link
Copy Markdown
Member

@skl skl commented Mar 3, 2026

Summary

Skip Docker Hub login in test workflows when credentials are not available. This prevents workflows from failing on fork PRs and Dependabot/Renovate PRs while preserving rate limit avoidance when credentials are present.

Changes

  • Added conditional to 5 test workflows: if: secrets.DOCKER_TOKEN_EBPF_INSTRUMENTATION != ''
  • Affects: pull_request_integration_tests, pull_request_integration_tests_arm, pull_request_k8s_integration_tests, pull_request_oats_test, workflow_integration_tests_vm
  • Docker Hub login is only needed for pull rate limits in tests, so gracefully skipping when unavailable is safe

Checklist

  • Changes tested to prevent workflow failures on forks
  • If this enhances / fixes / changes a core feature, I have updated the features documentation

@skl skl requested a review from a team as a code owner March 3, 2026 18:37
@linux-foundation-easycla
Copy link
Copy Markdown

linux-foundation-easycla Bot commented Mar 3, 2026

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: skl / name: Stephen Lang (0e0e0e4)

Add conditional step to skip Docker Hub login in test workflows when the DOCKER_TOKEN_EBPF_INSTRUMENTATION secret is not available. This prevents workflows from failing on fork PRs, Dependabot/Renovate PRs, and other contexts where repository secrets are not accessible, while preserving login for rate limit avoidance when credentials are available.
@skl skl force-pushed the skl/optional-docker-login branch from 9a31c80 to 0e0e0e4 Compare March 3, 2026 18:39
@MrAlias MrAlias merged commit c045b0c into open-telemetry:main Mar 3, 2026
13 checks passed
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 3, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 44.63%. Comparing base (0c90307) to head (0e0e0e4).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1439      +/-   ##
==========================================
+ Coverage   43.74%   44.63%   +0.89%     
==========================================
  Files         312      311       -1     
  Lines       33911    28681    -5230     
==========================================
- Hits        14834    12803    -2031     
+ Misses      18120    15103    -3017     
+ Partials      957      775     -182     
Flag Coverage Δ
integration-test ?
integration-test-arm ?
integration-test-vm-x86_64-5.15.152 ?
integration-test-vm-x86_64-6.10.6 ?
k8s-integration-test ?
oats-test ?
unittests 44.63% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@MrAlias MrAlias added this to the v0.6.0 milestone Mar 5, 2026
@MrAlias MrAlias mentioned this pull request Mar 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants