Skip to content

Fix HTTP request parsing#1412

Merged
mmat11 merged 5 commits into
open-telemetry:mainfrom
rafaelroquetto:fix_http_req_buf
Mar 4, 2026
Merged

Fix HTTP request parsing#1412
mmat11 merged 5 commits into
open-telemetry:mainfrom
rafaelroquetto:fix_http_req_buf

Conversation

@rafaelroquetto
Copy link
Copy Markdown
Contributor

HTTP requests not always have a request-target starting with / - it could be a fully qualified target (e.g. GET http://example.com/path HTTP/1.1 or even GET *).

Fixes grafana/beyla#2528

Checklist

@rafaelroquetto rafaelroquetto requested a review from a team as a code owner March 2, 2026 23:28
Copy link
Copy Markdown
Contributor

@grcevski grcevski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 3, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 43.89%. Comparing base (0970a01) to head (d76745d).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1412   +/-   ##
=======================================
  Coverage   43.89%   43.89%           
=======================================
  Files         313      313           
  Lines       34213    34213           
=======================================
  Hits        15018    15018           
+ Misses      18217    18215    -2     
- Partials      978      980    +2     
Flag Coverage Δ
integration-test 21.53% <ø> (ø)
integration-test-arm 0.00% <ø> (ø)
integration-test-vm-x86_64-5.15.152 0.00% <ø> (ø)
integration-test-vm-x86_64-6.10.6 0.00% <ø> (ø)
k8s-integration-test 2.29% <ø> (ø)
oats-test 0.00% <ø> (ø)
unittests 44.89% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Comment thread bpf/common/http_types.h Outdated
@rafaelroquetto rafaelroquetto force-pushed the fix_http_req_buf branch 2 times, most recently from b25ba2e to 3b399ca Compare March 3, 2026 21:15
@rafaelroquetto rafaelroquetto reopened this Mar 3, 2026
@rafaelroquetto
Copy link
Copy Markdown
Contributor Author

DO NOT MERGE until all tests/checks are run

@rafaelroquetto
Copy link
Copy Markdown
Contributor Author

All relevant tests have run, and are green. Feel free to merge.

@mmat11 mmat11 merged commit 17b9c8c into open-telemetry:main Mar 4, 2026
65 checks passed
@rafaelroquetto rafaelroquetto deleted the fix_http_req_buf branch March 4, 2026 01:01
@MrAlias MrAlias added this to the v0.6.0 milestone Mar 5, 2026
@MrAlias MrAlias mentioned this pull request Mar 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Missing http_server application metrics

4 participants