Skip to content

fix(security): update node component lockfiles for qs >= 6.14.2#1396

Merged
MrAlias merged 1 commit into
open-telemetry:mainfrom
MrAlias:update-npm-qs
Mar 2, 2026
Merged

fix(security): update node component lockfiles for qs >= 6.14.2#1396
MrAlias merged 1 commit into
open-telemetry:mainfrom
MrAlias:update-npm-qs

Conversation

@MrAlias
Copy link
Copy Markdown
Contributor

@MrAlias MrAlias commented Mar 2, 2026

Update node component lockfiles for qs >= 6.14.2.

What changed

  • Updated lockfile resolutions in:
    • internal/test/integration/components/nodejsdist/package-lock.json
    • internal/test/integration/components/nodejsserver/package-lock.json
    • internal/test/integration/components/nodemultiproc/package-lock.json
    • internal/test/integration/components/tpclient/package-lock.json
  • Transitive qs is now resolved to fixed versions (6.14.2+).
  • body-parser was updated transitively where needed (notably to 1.20.4), which allows fixed qs resolution.

Why

Dependabot flagged vulnerable qs versions in integration component lockfiles. The previous lockfiles were out of sync with currently resolvable versions allowed by dependency ranges. Dependabot was not able to generate an automatic fix PR for this.

Validation

  • Ran lockfile-only updates per component:
    • npm update body-parser qs --package-lock-only
  • Re-scanned repo lockfiles for qs < 6.14.2 and found no remaining matches.

Regenerate package-lock.json files for node integration components.

- update transitive qs to >=6.14.2 (6.14.2/6.15.0)
- pick up body-parser 1.20.4 where applicable
- remove older nested qs resolutions from express tree
@MrAlias MrAlias added this to the v0.6.0 milestone Mar 2, 2026
Copilot AI review requested due to automatic review settings March 2, 2026 21:49
@MrAlias MrAlias requested a review from a team as a code owner March 2, 2026 21:49
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

Files not reviewed (4)
  • internal/test/integration/components/nodejsdist/package-lock.json: Language not supported
  • internal/test/integration/components/nodejsserver/package-lock.json: Language not supported
  • internal/test/integration/components/nodemultiproc/package-lock.json: Language not supported
  • internal/test/integration/components/tpclient/package-lock.json: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 2, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 43.74%. Comparing base (c3debef) to head (08e86a4).
⚠️ Report is 13 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1396      +/-   ##
==========================================
+ Coverage   41.32%   43.74%   +2.41%     
==========================================
  Files         297      312      +15     
  Lines       32742    33911    +1169     
==========================================
+ Hits        13532    14834    +1302     
+ Misses      18193    18120      -73     
+ Partials     1017      957      -60     
Flag Coverage Δ
integration-test 21.54% <ø> (+0.02%) ⬆️
integration-test-arm 0.00% <ø> (ø)
integration-test-vm-x86_64-5.15.152 0.00% <ø> (ø)
integration-test-vm-x86_64-6.10.6 0.00% <ø> (ø)
k8s-integration-test 2.31% <ø> (ø)
oats-test 0.00% <ø> (ø)
unittests 44.63% <ø> (+3.95%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@MrAlias MrAlias merged commit 55ccde9 into open-telemetry:main Mar 2, 2026
69 checks passed
@MrAlias MrAlias deleted the update-npm-qs branch March 2, 2026 23:18
@MrAlias MrAlias mentioned this pull request Mar 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants