Skip to content

Add integration test for sock_iter pre-existing socket tracking#1379

Merged
grcevski merged 2 commits into
open-telemetry:mainfrom
rafaelroquetto:sock_iter_test
Feb 27, 2026
Merged

Add integration test for sock_iter pre-existing socket tracking#1379
grcevski merged 2 commits into
open-telemetry:mainfrom
rafaelroquetto:sock_iter_test

Conversation

@rafaelroquetto
Copy link
Copy Markdown
Contributor

Validates that the obi_sk_iter_tcp correctly registers TCP sockets that exist before OBI starts, so that obi_packet_extender (sk_msg) can inject Traceparent headers into requests sent over those pre-existing connections.

The test uses an echo endpoint to prove wire-level header injection: the server reflects back any Traceparent it receives, which cannot be faked by OBI's internal black box context propagation correlation.

Checklist

@rafaelroquetto rafaelroquetto requested a review from a team as a code owner February 27, 2026 01:59
@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 27, 2026

Codecov Report

❌ Patch coverage is 0% with 45 lines in your changes missing coverage. Please review.
✅ Project coverage is 43.69%. Comparing base (dda9420) to head (5031913).
⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
...est/integration/components/keepaliveclient/main.go 0.00% 36 Missing ⚠️
...t/integration/components/tpinjector-server/main.go 0.00% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1379      +/-   ##
==========================================
- Coverage   43.75%   43.69%   -0.07%     
==========================================
  Files         310      312       +2     
  Lines       33772    33817      +45     
==========================================
- Hits        14777    14775       -2     
- Misses      18046    18092      +46     
- Partials      949      950       +1     
Flag Coverage Δ
integration-test 21.59% <ø> (-0.21%) ⬇️
integration-test-arm 0.00% <ø> (ø)
integration-test-vm-x86_64-5.15.152 0.00% <ø> (ø)
integration-test-vm-x86_64-6.10.6 0.00% <ø> (ø)
k8s-integration-test 2.32% <ø> (ø)
oats-test 0.00% <ø> (ø)
unittests 44.56% <0.00%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Comment thread internal/test/integration/keepalive_test.go Outdated
Copy link
Copy Markdown
Contributor

@mmat11 mmat11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Copy link
Copy Markdown
Contributor

@grcevski grcevski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@grcevski grcevski merged commit 44ac9fd into open-telemetry:main Feb 27, 2026
65 checks passed
@rafaelroquetto rafaelroquetto deleted the sock_iter_test branch February 27, 2026 19:43
NimrodAvni78 pushed a commit to coralogix/opentelemetry-ebpf-instrumentation that referenced this pull request Mar 1, 2026
@MrAlias MrAlias added this to the v0.6.0 milestone Mar 2, 2026
@MrAlias MrAlias mentioned this pull request Mar 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants