Fix request buffer lookup when instrumenting servers#1377
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1377 +/- ##
=======================================
Coverage 43.75% 43.75%
=======================================
Files 310 310
Lines 33772 33772
=======================================
Hits 14777 14777
Misses 18044 18044
Partials 951 951
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
NimrodAvni78
pushed a commit
to coralogix/opentelemetry-ebpf-instrumentation
that referenced
this pull request
Mar 1, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When instrumenting servers, it is possible that their egress codepath now run through
tpinjectoras a result of the new iterator introduced by #1366There was a bug in k_tracer in which we forgot to sort the egress_key, thus never finding the buffer setup by sk_msg, which in turn made us never see the end of the request/response.
Checklist