gotracer: set trace context in shared map for http and other protocols#1370
Conversation
mmat11
commented
Feb 26, 2026
- set trace context in shared map for http and other protocols
- refactor go probes with gotracer/maps/ and gotracer/types/
- remove unused hpack.h
9a7d415 to
e6082bc
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1370 +/- ##
=======================================
Coverage 43.75% 43.75%
=======================================
Files 310 310
Lines 33772 33772
=======================================
Hits 14777 14777
Misses 18044 18044
Partials 951 951
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
rafaelroquetto
left a comment
There was a problem hiding this comment.
Man, these maps are complicated... but it LGTM, apart from the usage of macros - perhaps this is a good opportunity for us to migrate away from them in the code we are touching anyway, what do you think?
(I'm mostly referring to the #define <CONSTANT> statements that could be turned into enum { k_constant = X };
grcevski
left a comment
There was a problem hiding this comment.
LGTM! Looks great, do you know if the overhead increased now that we check all those maps in the runtime probe?
Signed-off-by: Mattia Meleleo <mattia.meleleo@coralogix.com>
e6082bc to
fffac4f
Compare
fffac4f to
a4c2d78
Compare
|
This branch Baseline (main) I think it's pretty much the same because the benchmark doesn't hit the last map lookup in order to hit the "slowest path" |
|
Amazing, thanks for doing the run @mmat11 ! |