Add SendTimeout field in kubecache config#1342
Merged
Merged
Conversation
pinoOgni
force-pushed
the
pgn/kubecache
branch
from
bc4c8ed to
2c23872
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1342 +/- ##
==========================================
- Coverage 43.75% 43.74% -0.02%
==========================================
Files 308 308
Lines 33497 33504 +7
==========================================
- Hits 14658 14656 -2
- Misses 17896 17906 +10
+ Partials 943 942 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
pinoOgni
force-pushed
the
pgn/kubecache
branch
from
2c23872 to
ec41947
Compare
mmat11
approved these changes
Feb 23, 2026
Contributor
mmat11
left a comment
mmat11
left a comment
There was a problem hiding this comment.
can you rebase and run make generate-config-schema?
Signed-off-by: Giuseppe Ognibene <giuseppe.ognibene@coralogix.com>
pinoOgni
force-pushed
the
pgn/kubecache
branch
from
ec41947 to
d8dd065
Compare
Contributor
Author
rebased! Nothing changed in the schema because we are using only |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR allows to set the
SendTimeoutvalue of thek8s-cachecomponent during configuration.It also adds some config validations.