refactor: apply const to bpf variables #1341
Merged
Merged
Conversation
rafaelroquetto
approved these changes
Feb 20, 2026
Contributor
rafaelroquetto
left a comment
rafaelroquetto
left a comment
There was a problem hiding this comment.
Yes! Thank you so so much for this!!!!
I will see if I can find a linter to help us enforce this moving forward. This is great!
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1341 +/- ##
=======================================
Coverage 43.75% 43.76%
=======================================
Files 308 308
Lines 33497 33497
=======================================
+ Hits 14658 14661 +3
+ Misses 17896 17894 -2
+ Partials 943 942 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mmat11
approved these changes
Feb 20, 2026
mmat11
approved these changes
Feb 23, 2026
Contributor
mmat11
left a comment
mmat11
left a comment
There was a problem hiding this comment.
can be merged after rebase
mmat11
reviewed
Feb 23, 2026
mmat11
reviewed
Feb 23, 2026
Signed-off-by: Giuseppe Ognibene <giuseppe.ognibene@coralogix.com>
Signed-off-by: Giuseppe Ognibene <giuseppe.ognibene@coralogix.com>
Signed-off-by: Giuseppe Ognibene <giuseppe.ognibene@coralogix.com>
Signed-off-by: Giuseppe Ognibene <giuseppe.ognibene@coralogix.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the first phase of what I hope will be a larger refactoring.
This PR updates variable declarations to use the
constacross the following bpf directories:Add
constis a best practice that offers various benefits like readability, intent and safety. It should also add compiler optimization and help the verifier.I find the code much more readable this way, I hope it works for you.