Skip to content

Add lint-fix make target#1337

Merged
mariomac merged 1 commit into
open-telemetry:mainfrom
MrAlias:make-fix-lint
Feb 20, 2026
Merged

Add lint-fix make target#1337
mariomac merged 1 commit into
open-telemetry:mainfrom
MrAlias:make-fix-lint

Conversation

@MrAlias
Copy link
Copy Markdown
Contributor

@MrAlias MrAlias commented Feb 19, 2026

DRY: refactor lint to use the added lint-run as well as the added lint-fix

@MrAlias MrAlias added this to the v0.6.0 milestone Feb 19, 2026
@MrAlias MrAlias requested a review from a team as a code owner February 19, 2026 21:56
Copilot AI review requested due to automatic review settings February 19, 2026 21:56
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refactors the lint target in the Makefile to follow the DRY (Don't Repeat Yourself) principle by introducing a shared lint-run target and adding a new lint-fix target that enables automatic fixing of linting issues.

Changes:

  • Introduced a new lint-run target that contains the core linting logic
  • Refactored the lint target to use target-specific variables and depend on lint-run
  • Added a new lint-fix target that passes --fix to golangci-lint for automatic fixes

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 19, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 44.35%. Comparing base (431a3ca) to head (9c7f3c8).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1337      +/-   ##
==========================================
+ Coverage   43.56%   44.35%   +0.78%     
==========================================
  Files         307      306       -1     
  Lines       32888    27760    -5128     
==========================================
- Hits        14329    12314    -2015     
+ Misses      17641    14713    -2928     
+ Partials      918      733     -185     
Flag Coverage Δ
integration-test ?
integration-test-arm ?
integration-test-vm-x86_64-5.15.152 ?
integration-test-vm-x86_64-6.10.6 ?
k8s-integration-test ?
oats-test ?
unittests 44.35% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mariomac mariomac merged commit 7f9ab62 into open-telemetry:main Feb 20, 2026
16 checks passed
@MrAlias MrAlias deleted the make-fix-lint branch February 20, 2026 15:17
@MrAlias MrAlias mentioned this pull request Mar 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants