Fix flaky disablekeepalives test

[mariomac]

Checklist

• If this enhances / fixes / changes a core feature, I have updated the features documentation

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 43.57%. Comparing base (2b13ee5) to head (ab25330).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1328      +/-   ##
==========================================
+ Coverage   43.51%   43.57%   +0.05%     
==========================================
  Files         305      305              
  Lines       32866    32877      +11     
==========================================
+ Hits        14303    14327      +24     
+ Misses      17642    17629      -13     
  Partials      921      921              

Flag	Coverage Δ
integration-test	21.48% <ø> (+0.02%)	⬆️
integration-test-arm	0.00% <ø> (ø)
integration-test-vm-x86_64-5.15.152	0.00% <ø> (ø)
integration-test-vm-x86_64-6.10.6	0.00% <ø> (ø)
k8s-integration-test	2.36% <ø> (+<0.01%)	⬆️
oats-test	0.00% <ø> (ø)
unittests	44.37% <ø> (+0.07%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[rafaelroquetto]

LGTM - but I do have a question: I did see in the code that we sometimes insert a zeroed connection info into this map, but what does a zeroed connection info mean, semantically speaking?

[grcevski]

LGTM - but I do have a question: I did see in the code that we sometimes insert a zeroed connection info into this map, but what does a zeroed connection info mean, semantically speaking?

Zeroed connection will work, it means no information.

[grcevski]

LGTM - but I do have a question: I did see in the code that we sometimes insert a zeroed connection info into this map, but what does a zeroed connection info mean, semantically speaking?

Zeroed connection will work, it means no information.

I think this means we couldn't find the information we needed. Perhaps we are cleaning up the connection information where we shouldn't, so maybe the keepalives fail because of this. We cleaned up on first request termination and from then on we don't supply it.

[grcevski]

I took a look at the code, it seems like we don't delete this info, so it must be a connection type we don't handle well and we've stored the empty connection info:

static __always_inline u8 get_conn_info(void *conn_ptr, connection_info_t *info) {
    if (conn_ptr) {
        void *fd_ptr = 0;
        off_table_t *ot = get_offsets_table();

        bpf_probe_read(
            &fd_ptr,
            sizeof(fd_ptr),
            (void *)(conn_ptr + go_offset_of(ot, (go_offset){.v = _conn_fd_pos}))); // find fd

        bpf_dbg_printk("Found fd, fd_ptr=%llx", fd_ptr);

        return get_conn_info_from_fd(fd_ptr, info);
    }

    return 0;
}

I think the fix is good.

[grcevski]

LGTM!