Skip to content

Omit -u option when building on podman.#1312

Merged
mariomac merged 1 commit into
open-telemetry:mainfrom
pilhuhn:fix-docker-generate-podman
Feb 17, 2026
Merged

Omit -u option when building on podman.#1312
mariomac merged 1 commit into
open-telemetry:mainfrom
pilhuhn:fix-docker-generate-podman

Conversation

@pilhuhn
Copy link
Copy Markdown
Contributor

@pilhuhn pilhuhn commented Feb 16, 2026

Passing the -u option to podman makes make docker-generate fail if OCI_BIN is set to podman.
Thanks for @mmat11 providing me a link to the Cilium build script
Closes: #1311

@pilhuhn pilhuhn requested a review from a team as a code owner February 16, 2026 14:05
Copy link
Copy Markdown
Contributor

@mariomac mariomac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! Thank you very much for your contribution

Copy link
Copy Markdown
Contributor

@mmat11 mmat11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 16, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 44.30%. Comparing base (3047a0a) to head (28bc62c).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1312      +/-   ##
==========================================
+ Coverage   43.53%   44.30%   +0.76%     
==========================================
  Files         305      304       -1     
  Lines       32864    27743    -5121     
==========================================
- Hits        14307    12291    -2016     
+ Misses      17638    14718    -2920     
+ Partials      919      734     -185     
Flag Coverage Δ
integration-test ?
integration-test-arm ?
k8s-integration-test ?
oats-test ?
unittests 44.30% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mariomac mariomac merged commit 9fb14cf into open-telemetry:main Feb 17, 2026
9 checks passed
@pilhuhn pilhuhn deleted the fix-docker-generate-podman branch February 17, 2026 09:01
@MrAlias MrAlias added this to the v0.6.0 milestone Feb 23, 2026
@MrAlias MrAlias mentioned this pull request Mar 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Change in bpf-files build breaks build on Linux wiht Podman

4 participants