Update the otel-collector example#1303
Merged
Merged
Conversation
Remove the build dir: otelcol-dev. Ignore the build dir. Update the configuration to a working state Update the documentation.
MrAlias
force-pushed
the
exp-otel-coll
branch
from
5fdd745 to
1f4653f
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1303 +/- ##
=======================================
Coverage 43.52% 43.52%
=======================================
Files 305 305
Lines 32864 32864
=======================================
+ Hits 14303 14305 +2
+ Misses 17640 17639 -1
+ Partials 921 920 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the examples/otel-collector workflow to stop committing the generated otelcol-dev distribution, refresh the OCB build config, and provide a working sample collector config + improved documentation for running OBI as an OpenTelemetry Collector receiver.
Changes:
- Remove the generated
examples/otel-collector/otelcol-devsource/module files from the repo and add a.gitignorerule for the generated output. - Update the collector
config.yamlto include abatchprocessor and wire it into the traces pipeline. - Refresh the example’s builder config and expand the README with setup/run/troubleshooting guidance.
Reviewed changes
Copilot reviewed 9 out of 11 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| examples/otel-collector/otelcol-dev/main_windows.go | Removed generated Windows entrypoint for the dev collector distribution. |
| examples/otel-collector/otelcol-dev/main_others.go | Removed generated non-Windows entrypoint for the dev collector distribution. |
| examples/otel-collector/otelcol-dev/main.go | Removed generated main for the dev collector distribution. |
| examples/otel-collector/otelcol-dev/components.go | Removed generated factory wiring for the dev collector distribution. |
| examples/otel-collector/otelcol-dev/go.mod | Removed generated Go module file for the dev collector distribution. |
| examples/otel-collector/otelcol-dev/go.sum | Removed generated dependency lockfile for the dev collector distribution. |
| examples/otel-collector/config.yaml | Adds batch processor config and attaches it to the traces pipeline; cleans up exporter config. |
| examples/otel-collector/builder-config.yaml | Updates OCB config (versions + local replace + OBI receiver import). |
| examples/otel-collector/README.md | Rewrites/expands instructions for generating eBPF assets, building with OCB, running, and troubleshooting. |
| examples/otel-collector/Dockerfile | Minor documentation note added (but currently still assumes a pre-existing otelcol-dev dir). |
| .gitignore | Ignores the generated examples/otel-collector/otelcol-dev/* output. |
Comments suppressed due to low confidence (1)
examples/otel-collector/Dockerfile:22
- The Docker build currently assumes
examples/otel-collector/otelcol-devexists in the repository (WORKDIR /app/examples/otel-collector/otelcol-dev+go build ...). This PR deletes/ignores that directory, sodocker buildwill fail unless the Dockerfile generates the collector distribution first (e.g., runocb --config examples/otel-collector/builder-config.yamlin the builder stage and then build/copy the resulting binary from the generated output_path).
# Note: libc6-compat is not needed since the binary is statically linked
WORKDIR /
COPY --from=builder /app/examples/otel-collector/otelcol-dev/otelcol-dev /otelcol
COPY examples/otel-collector/config.yaml /etc/otelcol/config.yaml
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
|
For the failing tests it seems example.com is down or throttling us. Maybe we should pick something else? I hope it passes. |
Contributor
|
Something is up with the example.com certificate, the Java service hits this when making the client call: I'm replacing with google.com and I'll push a fix with my PR. |
Contributor
|
Pushed fix here: #1304 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.