Skip to content

Rename all kube.Store and store.InMemory fields for consistency#1297

Merged
MrAlias merged 4 commits into
open-telemetry:mainfrom
coralogix:pgn/store
Feb 13, 2026
Merged

Rename all kube.Store and store.InMemory fields for consistency#1297
MrAlias merged 4 commits into
open-telemetry:mainfrom
coralogix:pgn/store

Conversation

@pinoOgni
Copy link
Copy Markdown
Contributor

@pinoOgni pinoOgni commented Feb 13, 2026

Right now we have different names for variables of the following type:

  • kube.Store: db, k8sStore, metaStore, metadata, meta or store
  • store.InMemory: ipToHosts or dnsDB

This PR renames all kube.Store fields to store and all store.InMemory to dnsCache (maybe cache?) to have consistent naming in the entire project. It also updates the pipeline-map doc.

Signed-off-by: Giuseppe Ognibene <giuseppe.ognibene@coralogix.com>
Signed-off-by: Giuseppe Ognibene <giuseppe.ognibene@coralogix.com>
Signed-off-by: Giuseppe Ognibene <giuseppe.ognibene@coralogix.com>
Signed-off-by: Giuseppe Ognibene <giuseppe.ognibene@coralogix.com>
@pinoOgni pinoOgni requested a review from a team as a code owner February 13, 2026 12:03
@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 13, 2026

Codecov Report

❌ Patch coverage is 49.05660% with 27 lines in your changes missing coverage. Please review.
✅ Project coverage is 43.41%. Comparing base (03f80bc) to head (1e8b6ce).
⚠️ Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
pkg/transform/k8s.go 60.00% 6 Missing ⚠️
pkg/transform/name_resolver.go 66.66% 3 Missing and 2 partials ⚠️
pkg/appolly/discover/container_updater.go 0.00% 4 Missing ⚠️
pkg/internal/netolly/transform/k8s/kubernetes.go 0.00% 4 Missing ⚠️
pkg/kube/informer_provider.go 0.00% 4 Missing ⚠️
pkg/internal/netolly/flow/reverse_dns.go 0.00% 3 Missing ⚠️
pkg/appolly/discover/finder.go 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1297      +/-   ##
==========================================
- Coverage   43.41%   43.41%   -0.01%     
==========================================
  Files         304      304              
  Lines       32779    32779              
==========================================
- Hits        14232    14230       -2     
- Misses      17630    17631       +1     
- Partials      917      918       +1     
Flag Coverage Δ
integration-test 21.05% <19.23%> (-0.06%) ⬇️
integration-test-arm 0.00% <0.00%> (ø)
k8s-integration-test 2.36% <0.00%> (-0.01%) ⬇️
oats-test 0.00% <0.00%> (ø)
unittests 44.28% <46.15%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Contributor

@grcevski grcevski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing! LGTM!

@MrAlias MrAlias merged commit a4a61b3 into open-telemetry:main Feb 13, 2026
47 checks passed
@MrAlias MrAlias added this to the v0.6.0 milestone Feb 23, 2026
@MrAlias MrAlias mentioned this pull request Mar 5, 2026
@pinoOgni pinoOgni deleted the pgn/store branch March 13, 2026 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants