Decouple arch from release target#1294
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1294 +/- ##
==========================================
+ Coverage 43.41% 44.28% +0.86%
==========================================
Files 304 303 -1
Lines 32779 27672 -5107
==========================================
- Hits 14232 12254 -1978
+ Misses 17630 14687 -2943
+ Partials 917 731 -186
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Still trying to verify these changes here: https://github.com/MrAlias/opentelemetry-ebpf-instrumentation/actions/runs/21963308522 One thing that I realized though is that these changes will not be applied to the artifact build in the release pipeline for the I think because of that what I'll do is let the CI build/tag/push the docker images and manually build the binaries and draft the release. |
Verified 🎉 |
There was a problem hiding this comment.
Pull request overview
This PR fixes the release workflow by decoupling the target architecture from the make release target, so CI (and users) explicitly build release artifacts per-architecture instead of the Makefile attempting to build multiple architectures in one invocation.
Changes:
- Add
RELEASE_DIR(default./dist) and update thereleasetarget to produce and verify a single-architecture artifact per run. - Update the GitHub Release workflow to run
make releasetwice (once foramd64, once forarm64).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
Makefile |
Refactors release to package/verify one GOARCH at a time and parameterizes the output directory via RELEASE_DIR. |
.github/workflows/release.yml |
Splits the artifact build step into two explicit architecture builds by setting GOARCH per step. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Fix the
Releaseworkflow. Thereleasemake target is trying to build bothamd64andarm64. Instead, have the user explicitly runmakewith these options. Consequentially update the release workflow to use make in this way.Validating this workflow in my fork here. The flaky-ness of the CI system has been blocking a successful run from hours now. I'll wait on a partial success there (obviously the docker image push and draft release shouldn't be successful based on permissions).