Skip to content

Decouple arch from release target#1294

Merged
MrAlias merged 3 commits into
open-telemetry:mainfrom
MrAlias:decop-release
Feb 12, 2026
Merged

Decouple arch from release target#1294
MrAlias merged 3 commits into
open-telemetry:mainfrom
MrAlias:decop-release

Conversation

@MrAlias
Copy link
Copy Markdown
Contributor

@MrAlias MrAlias commented Feb 12, 2026

Fix the Release workflow. The release make target is trying to build both amd64 and arm64. Instead, have the user explicitly run make with these options. Consequentially update the release workflow to use make in this way.

Validating this workflow in my fork here. The flaky-ness of the CI system has been blocking a successful run from hours now. I'll wait on a partial success there (obviously the docker image push and draft release shouldn't be successful based on permissions).

@MrAlias MrAlias added this to the v0.6.0 milestone Feb 12, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 12, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 44.28%. Comparing base (03f80bc) to head (475deca).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1294      +/-   ##
==========================================
+ Coverage   43.41%   44.28%   +0.86%     
==========================================
  Files         304      303       -1     
  Lines       32779    27672    -5107     
==========================================
- Hits        14232    12254    -1978     
+ Misses      17630    14687    -2943     
+ Partials      917      731     -186     
Flag Coverage Δ
integration-test ?
integration-test-arm ?
k8s-integration-test ?
oats-test ?
unittests 44.28% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Contributor

@grcevski grcevski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! LGTM!

@MrAlias
Copy link
Copy Markdown
Contributor Author

MrAlias commented Feb 12, 2026

Still trying to verify these changes here: https://github.com/MrAlias/opentelemetry-ebpf-instrumentation/actions/runs/21963308522

One thing that I realized though is that these changes will not be applied to the artifact build in the release pipeline for the v0.5.0 tag. That job in the workflow will checkout v0.5.0, which is the old commit that does not have these changes.

I think because of that what I'll do is let the CI build/tag/push the docker images and manually build the binaries and draft the release.

@MrAlias
Copy link
Copy Markdown
Contributor Author

MrAlias commented Feb 12, 2026

Still trying to verify these changes here: https://github.com/MrAlias/opentelemetry-ebpf-instrumentation/actions/runs/21963308522

Verified 🎉

@MrAlias MrAlias marked this pull request as ready for review February 12, 2026 23:30
@MrAlias MrAlias requested a review from a team as a code owner February 12, 2026 23:30
Copilot AI review requested due to automatic review settings February 12, 2026 23:30
@MrAlias MrAlias merged commit 1c01b5b into open-telemetry:main Feb 12, 2026
13 checks passed
@MrAlias MrAlias deleted the decop-release branch February 12, 2026 23:31
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes the release workflow by decoupling the target architecture from the make release target, so CI (and users) explicitly build release artifacts per-architecture instead of the Makefile attempting to build multiple architectures in one invocation.

Changes:

  • Add RELEASE_DIR (default ./dist) and update the release target to produce and verify a single-architecture artifact per run.
  • Update the GitHub Release workflow to run make release twice (once for amd64, once for arm64).

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
Makefile Refactors release to package/verify one GOARCH at a time and parameterizes the output directory via RELEASE_DIR.
.github/workflows/release.yml Splits the artifact build step into two explicit architecture builds by setting GOARCH per step.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread Makefile
@MrAlias MrAlias mentioned this pull request Mar 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants