Skip to content

ci: fix ParseAddr("localhost"): unable to parse IP #1293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MrAlias merged 3 commits into from
Feb 12, 2026
Merged

ci: fix ParseAddr("localhost"): unable to parse IP #1293

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fde02da
ignore: empty commit to trigger ci
skl Feb 12, 2026
b1cea4d
ignore: trigger integration tests
skl Feb 12, 2026
7d64ee3
ci: s/localhost/127.0.0.1
skl Feb 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions internal/test/integration/dockerutil_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ func setupContainerPrometheus(t *testing.T, network *dockertest.Network, configF
},
ExposedPorts: []string{"9090/tcp"},
PortBindings: map[docker.Port][]docker.PortBinding{
"9090/tcp": {{HostIP: "localhost", HostPort: "9090"}},
"9090/tcp": {{HostIP: "127.0.0.1", HostPort: "9090"}},
},
})
require.NoError(t, err, "could not start Prometheus container")
Expand All @@ -74,7 +74,7 @@ func setupContainerJaeger(t *testing.T, network *dockertest.Network) {
},
ExposedPorts: []string{"16686/tcp", "4317/tcp", "4318/tcp"},
PortBindings: map[docker.Port][]docker.PortBinding{
"16686/tcp": {{HostIP: "localhost", HostPort: "16686"}},
"16686/tcp": {{HostIP: "127.0.0.1", HostPort: "16686"}},
},
})
require.NoError(t, err, "could not start Jaeger container")
Expand Down Expand Up @@ -184,7 +184,7 @@ func (o obi) instrument(t *testing.T, network *dockertest.Network, resource *doc
Privileged: true,
ExposedPorts: []string{"8999/tcp"},
PortBindings: map[docker.Port][]docker.PortBinding{
"8999/tcp": {{HostIP: "localhost", HostPort: "8999"}},
"8999/tcp": {{HostIP: "127.0.0.1", HostPort: "8999"}},
},
}, func(hc *docker.HostConfig) {
hc.PidMode = "container:" + resource.Container.ID
Expand Down
2 changes: 1 addition & 1 deletion internal/test/integration/http_go_otel_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ func setupGoOTelTestServer(t *testing.T, network *dockertest.Network, env []stri
Env: env,
ExposedPorts: []string{"8080/tcp"},
PortBindings: map[docker.Port][]docker.PortBinding{
"8080/tcp": {{HostIP: "localhost", HostPort: "8080"}},
"8080/tcp": {{HostIP: "127.0.0.1", HostPort: "8080"}},
},
})
require.NoError(t, err, "could not start test server container")
Expand Down