Skip to content

Release artifact fixes#1288

Merged
MrAlias merged 5 commits into
open-telemetry:mainfrom
MrAlias:release-artifact-fixes
Feb 11, 2026
Merged

Release artifact fixes#1288
MrAlias merged 5 commits into
open-telemetry:mainfrom
MrAlias:release-artifact-fixes

Conversation

@MrAlias
Copy link
Copy Markdown
Contributor

@MrAlias MrAlias commented Feb 11, 2026

@MrAlias MrAlias added this to the v0.6.0 milestone Feb 11, 2026
Resolves the error where the docker image builds are missing the
Dockerhub password on login.
@MrAlias MrAlias force-pushed the release-artifact-fixes branch from 27bdb40 to 9b726db Compare February 11, 2026 19:25
@MrAlias MrAlias marked this pull request as ready for review February 11, 2026 19:27
@MrAlias MrAlias requested a review from a team as a code owner February 11, 2026 19:27
Copilot AI review requested due to automatic review settings February 11, 2026 19:27
Copy link
Copy Markdown
Contributor

@grcevski grcevski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses release pipeline failures by ensuring release artifact generation uses the correct host build parameters and by correctly passing Docker Hub credentials into reusable publishing workflows.

Changes:

  • Update make docker-generate to set GOOS/GOARCH explicitly when running go generate.
  • Pass Docker Hub token into reusable Docker publish workflows from release.yml.
  • Declare DOCKER_TOKEN_EBPF_INSTRUMENTATION as a required workflow_call secret in the reusable Docker publish workflows.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
Makefile Adjusts env passed to go generate in docker-generate to avoid release artifact build failures.
.github/workflows/release.yml Passes Docker Hub token into reusable publish workflows so they can authenticate during release.
.github/workflows/publish_dockerhub_main.yml Declares required workflow_call secret for Docker Hub token used by docker/login-action.
.github/workflows/publish_dockerhub_k8s_cache_main.yml Declares required workflow_call secret for Docker Hub token used by docker/login-action.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread Makefile Outdated
@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 11, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 44.27%. Comparing base (44d79b5) to head (639ca49).
⚠️ Report is 1 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (44d79b5) and HEAD (639ca49). Click for more details.

HEAD has 29 uploads less than BASE
Flag BASE (44d79b5) HEAD (639ca49)
oats-test 5 0
k8s-integration-test 15 0
integration-test 9 0
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1288      +/-   ##
==========================================
- Coverage   51.43%   44.27%   -7.16%     
==========================================
  Files         303      303              
  Lines       27672    27672              
==========================================
- Hits        14232    12252    -1980     
- Misses      12523    14690    +2167     
+ Partials      917      730     -187     
Flag Coverage Δ
integration-test ?
k8s-integration-test ?
oats-test ?
unittests 44.27% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@MrAlias
Copy link
Copy Markdown
Contributor Author

MrAlias commented Feb 11, 2026

Validating locally. Still not convinced the Makefile changes are correct.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread Makefile Outdated
Comment thread Makefile
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@MrAlias MrAlias merged commit 35e78af into open-telemetry:main Feb 11, 2026
9 checks passed
@MrAlias MrAlias deleted the release-artifact-fixes branch February 11, 2026 21:10
@MrAlias MrAlias mentioned this pull request Mar 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants