Release artifact fixes#1288
Conversation
Resolves the error where the docker image builds are missing the Dockerhub password on login.
27bdb40 to
9b726db
Compare
There was a problem hiding this comment.
Pull request overview
This PR addresses release pipeline failures by ensuring release artifact generation uses the correct host build parameters and by correctly passing Docker Hub credentials into reusable publishing workflows.
Changes:
- Update
make docker-generateto setGOOS/GOARCHexplicitly when runninggo generate. - Pass Docker Hub token into reusable Docker publish workflows from
release.yml. - Declare
DOCKER_TOKEN_EBPF_INSTRUMENTATIONas a requiredworkflow_callsecret in the reusable Docker publish workflows.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
Makefile |
Adjusts env passed to go generate in docker-generate to avoid release artifact build failures. |
.github/workflows/release.yml |
Passes Docker Hub token into reusable publish workflows so they can authenticate during release. |
.github/workflows/publish_dockerhub_main.yml |
Declares required workflow_call secret for Docker Hub token used by docker/login-action. |
.github/workflows/publish_dockerhub_k8s_cache_main.yml |
Declares required workflow_call secret for Docker Hub token used by docker/login-action. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests.
Additional details and impacted files@@ Coverage Diff @@
## main #1288 +/- ##
==========================================
- Coverage 51.43% 44.27% -7.16%
==========================================
Files 303 303
Lines 27672 27672
==========================================
- Hits 14232 12252 -1980
- Misses 12523 14690 +2167
+ Partials 917 730 -187
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Validating locally. Still not convinced the |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Uh oh!
There was an error while loading. Please reload this page.