Skip to content

Disable IP options by default#1001

Merged
grcevski merged 2 commits into
open-telemetry:mainfrom
rafaelroquetto:tp_inject_opts
Dec 12, 2025
Merged

Disable IP options by default#1001
grcevski merged 2 commits into
open-telemetry:mainfrom
rafaelroquetto:tp_inject_opts

Conversation

@rafaelroquetto
Copy link
Copy Markdown
Contributor

@rafaelroquetto rafaelroquetto commented Dec 12, 2025

IP options have proven to be dangerous - routers usually drop them for a myriad of reasons (see RFC-7126, RFC-9098 and RFC-7872 for a rationale.

This PR disables IP option injection by default - users who need them must explicitly enable them in the config, as they are not long implied in all - most use cases are handled by TCP options anyway.

Resolves grafana/beyla#2293

@rafaelroquetto rafaelroquetto requested a review from a team as a code owner December 12, 2025 00:40
@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 12, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 47.17%. Comparing base (816e7b5) to head (1609de4).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1001   +/-   ##
=======================================
  Coverage   47.17%   47.17%           
=======================================
  Files         259      259           
  Lines       26859    26859           
=======================================
  Hits        12670    12670           
  Misses      13344    13344           
  Partials      845      845           
Flag Coverage Δ
integration-test 23.05% <ø> (ø)
integration-test-arm 0.00% <ø> (ø)
integration-test-vm-${ARCH}-${KERNEL_VERSION} 0.00% <ø> (ø)
k8s-integration-test 2.70% <ø> (+0.01%) ⬆️
oats-test 0.00% <ø> (ø)
unittests 48.19% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Contributor

@mmat11 mmat11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there's one failing test, the rest lgtm!

Copy link
Copy Markdown
Contributor

@grcevski grcevski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@grcevski grcevski merged commit 400e9a7 into open-telemetry:main Dec 12, 2025
64 of 65 checks passed
@MrAlias MrAlias added this to the v0.4.0 milestone Jan 8, 2026
@MrAlias MrAlias mentioned this pull request Jan 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Beyla interferes with IPv6 SSL connectivity with context_propagation: all enabled

5 participants