Disable IP options by default#1001
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1001 +/- ##
=======================================
Coverage 47.17% 47.17%
=======================================
Files 259 259
Lines 26859 26859
=======================================
Hits 12670 12670
Misses 13344 13344
Partials 845 845
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mmat11
approved these changes
Dec 12, 2025
Contributor
mmat11
left a comment
There was a problem hiding this comment.
there's one failing test, the rest lgtm!
skl
approved these changes
Dec 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IP options have proven to be dangerous - routers usually drop them for a myriad of reasons (see RFC-7126, RFC-9098 and RFC-7872 for a rationale.
This PR disables IP option injection by default - users who need them must explicitly enable them in the config, as they are not long implied in
all- most use cases are handled by TCP options anyway.Resolves grafana/beyla#2293