Repository navigation
[OpenTelemetry] Do not follow links to self-diagnostics logs - #7968
Merged
martincostello merged 4 commits intoOct 16, 2026
Merged
Conversation
Always create self-diagnostics log files as new files so that an existing symbolic link with the same name is never followed. Assisted-by: Claude Code (Claude Opus 5.5) <noreply@anthropic.com> Discovered by Anthropic's OSS Scanner, as vulnerability ANT-2026-F9YHIZLY.
Add PR number. Assisted-by: Claude Code (Claude Opus 5.5) <noreply@anthropic.com> Discovered by Anthropic's OSS Scanner, as vulnerability ANT-2026-F9YHIZLY.
Pull request dashboard statusMerged · refreshed 2026-10-16 20:00 UTC Status above doesn't look right?
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7968 +/- ##
==========================================
+ Coverage 92.84% 92.86% +0.01%
==========================================
Files 365 365
Lines 21328 21331 +3
==========================================
+ Hits 19801 19808 +7
+ Misses 1527 1523 -4
Flags with carried forward coverage won't be shown. Click here to find out more.
|
matt-hensley
approved these changes
Oct 16, 2026
martincostello
enabled auto-merge
October 16, 2026 18:45
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Oct 16, 2026
This was referenced Oct 20, 2026
This was referenced Oct 22, 2026
Bump Microsoft.EntityFrameworkCore.Design and 9 others
BenFielder1/AI-Driven-Engineering-Platform#15
Open
Open
Open
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Discovered by Anthropic's OSS Scanner, as vulnerability ANT-2026-F9YHIZLY.
Changes
Always create self-diagnostics log files as new files instead of opening whatever already exists with the log file's name.
Both self-diagnostics log writers use predictable file names:
OTEL_DIAGNOSTICS.jsonwriter uses<executable>.<pid>.logand opened it withFileMode.Create.SelfDiagnosticsOptionsfile sink usesotel-dotnet-...-<index>.logand opened it withFileMode.Append.If another user who can write to the log directory created a symbolic link with one of those names, the process followed the link and truncated or appended to its target.
FileMode.CreateNew.FileMode.CreateNew. Its index is always past any existing file in the series, so an existing entry makes the open fail and the next attempt moves on to the next index.Merge requirement checklist
CHANGELOG.mdfile(s) updated for non-trivial changesChanges in public API reviewed (if applicable)Note
The changes in this PR and its description were generated with Claude Code (Claude Opus 5.5).
Footnotes
Yes, I can answer maintainer questions about the content of this PR without using AI. ↩