Repository navigation
[SDK] Redact wrapped inline secrets in self-diagnostics preambles - #7955
Merged
Merged
Conversation
Discovered by Anthropic's OSS Scanner, as bug ANT-2026-CKH8AP2O. Assisted-by: OpenAI Codex
Pull request dashboard statusMerged · refreshed 2026-10-16 11:22 UTC Status above doesn't look right?
|
Kielek
marked this pull request as ready for review
October 16, 2026 08:06
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7955 +/- ##
==========================================
- Coverage 92.30% 92.30% -0.01%
==========================================
Files 363 363
Lines 21035 21044 +9
==========================================
+ Hits 19416 19424 +8
- Misses 1619 1620 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
martincostello
approved these changes
Oct 16, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to a conflict with the base branch
Oct 16, 2026
This was referenced Oct 22, 2026
Closed
Bump Microsoft.EntityFrameworkCore.Design and 9 others
BenFielder1/AI-Driven-Engineering-Platform#15
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fix addresses a ANT-2026-CKH8AP2O finding from Anthropic's OSS Scanner.
Project enrollment: anthropics/oss-scanner#117.
Changes
Self-diagnostics could write a folded PEM value in a certificate-path environment
variable into the default log preamble when literal quotes preceded its armour.
Recognizable PEM material is now redacted wherever it occurs, including
whole-PEM base64 encoding, and quoted or prefixed JWTs are detected at token
boundaries.
Adds 17 regression cases for all three certificate variables, the real preamble,
resource attributes, ordinary certificate paths, and the existing disclosure
modes. Recognizable inline material redacts the whole setting, including resource
attributes. Explicit
AllValuesoutput remains available. No public API changes.Merge requirement checklist
CHANGELOG.mdfile(s) updated for non-trivial changes[ ] Changes in public API reviewed (if applicable; no public API changes)Footnotes
Yes, I can answer maintainer questions about the content of this PR without using AI. ↩