Repository navigation
[SDK] Compact metric storage after stream removal - #7945
Merged
martincostello merged 5 commits intoOct 15, 2026
Merged
Conversation
Pull request dashboard statusMerged · refreshed 2026-10-15 07:57 UTC Status above doesn't look right?
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7945 +/- ##
==========================================
- Coverage 92.28% 92.28% -0.01%
==========================================
Files 363 363
Lines 21022 21038 +16
==========================================
+ Hits 19401 19414 +13
- Misses 1621 1624 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
|
matt-hensley
marked this pull request as ready for review
October 14, 2026 19:43
martincostello
approved these changes
Oct 14, 2026
Co-authored-by: Martin Costello <martin@martincostello.com>
This was referenced Oct 15, 2026
Open
This was referenced Oct 16, 2026
Open
Open
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Removed metric streams leave empty slots in the reader's storage that the collect path keeps scanning. Collection slows as metric streams churn.
Storage is now compacted during collection, so only active streams are scanned.
Results (same session, same machine; churned vs. clean provider, ratio = churned / clean):
.NET 10.0
.NET Framework 4.7.2
** benchmark noise
Merge requirement checklist
CHANGELOG.mdfile(s) updated for non-trivial changesFootnotes
Yes, I can answer maintainer questions about the content of this PR without using AI. ↩