[SDK] Restore configured MaxScale after delta histogram collection - #7671
Merged
martincostello merged 5 commits intoAug 21, 2026
Merged
martincostello merged 5 commits into
martincostello merged 5 commits into
Conversation
matt-hensley
marked this pull request as ready for review
August 21, 2026 01:26
Pull request dashboard statusMerged · refreshed 2026-08-21 08:47 UTC Status above doesn't look right?
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7671 +/- ##
==========================================
- Coverage 91.39% 91.38% -0.02%
==========================================
Files 318 318
Lines 17810 17812 +2
==========================================
Hits 16278 16278
- Misses 1532 1534 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
martincostello
approved these changes
Aug 21, 2026
Use the result of `Assert.Single`.
This was referenced Sep 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Restores configured
MaxScaleafter a delta exponential-histogram is collected.MaxScaleis the maximum scale available to an exponential histogram stream, so resetting or copying the histogram should not discard that configuration, per the metrics SDK spec.This restores the config after collection and when copying a histogram, while preserving the reset behavior introduced in #6557.
Merge requirement checklist
CHANGELOG.mdfiles updated for non-trivial changes