[Exporter.Prometheus] Fix spec-compliance issues#7454
Merged
martincostello merged 7 commits intoJun 24, 2026
Conversation
- Fix double unit suffixes in metric names when using OpenMetrics. - Fix incorrect handling of leading digits in metric names for OpenMetrics. - Fix incorrect `Content-Type` for PrometheusText.
martincostello
added
the
spec-compliance
martincostello
commented
Jun 23, 2026
github-actions
Bot
added
pkg:OpenTelemetry.Exporter.Prometheus.AspNetCore
martincostello
commented
Jun 23, 2026
Add PR numbers.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7454 +/- ##
==========================================
- Coverage 89.94% 89.85% -0.10%
==========================================
Files 277 277
Lines 14637 14642 +5
==========================================
- Hits 13165 13156 -9
- Misses 1472 1486 +14
Flags with carried forward coverage won't be shown. Click here to find out more.
|
martincostello
marked this pull request as ready for review
June 23, 2026 17:17
martincostello
enabled auto-merge
June 23, 2026 17:18
Contributor
There was a problem hiding this comment.
Pull request overview
This PR targets spec-compliance fixes in the Prometheus exporters (HttpListener + ASP.NET Core), primarily around OpenMetrics metric naming and scrape response Content-Type generation.
Changes:
- Adjust OpenMetrics metric name sanitization (leading digits handling) and unit-suffix behavior for counters.
- Update
Content-Typegeneration logic and expand/adjust protocol-related test coverage. - Add changelog entries for both Prometheus exporter packages.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| test/OpenTelemetry.Exporter.Prometheus.HttpListener.Tests/PrometheusProtocolTests.cs | Adds GetContentType/ToString protocol tests (currently asserts PrometheusText omits charset). |
| test/OpenTelemetry.Exporter.Prometheus.HttpListener.Tests/PrometheusMetricTests.cs | Updates OpenMetrics naming tests (leading digits + unit/_total interactions). |
| test/OpenTelemetry.Exporter.Prometheus.HttpListener.Tests/PrometheusHttpListenerTests.cs | Updates integration expectations for scrape Content-Type. |
| test/OpenTelemetry.Exporter.Prometheus.AspNetCore.Tests/PrometheusIntegrationTests.cs | Updates ASP.NET Core scrape test Content-Type expectation. |
| test/OpenTelemetry.Exporter.Prometheus.AspNetCore.Tests/PrometheusExporterMiddlewareTests.cs | Updates middleware integration expectations for scrape Content-Type. |
| src/OpenTelemetry.Exporter.Prometheus.HttpListener/Internal/Shared/PrometheusProtocol.cs | Changes Content-Type composition (charset now conditional on OpenMetrics). |
| src/OpenTelemetry.Exporter.Prometheus.HttpListener/Internal/Shared/PrometheusMetric.cs | Fixes OpenMetrics unit suffix duplication for counters; adjusts leading-digit escaping behavior. |
| src/OpenTelemetry.Exporter.Prometheus.HttpListener/CHANGELOG.md | Records the spec-compliance fixes. |
| src/OpenTelemetry.Exporter.Prometheus.AspNetCore/CHANGELOG.md | Records the spec-compliance fixes. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Revert the changes to the `Content-Type` header's `charset`.
Fix issue with counter suffixes.
Rename tests to be less specific.
martincostello
commented
Jun 23, 2026
martincostello
commented
Jun 23, 2026
Fix changes that didn't get reverted.
Kielek
disabled auto-merge
June 24, 2026 05:47
Kielek
approved these changes
Jun 24, 2026
Kielek
left a comment
Kielek
left a comment
Member
There was a problem hiding this comment.
Pushed some direct feedback, please double check and merge if you are fine.
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Jun 24, 2026
This was referenced Jul 18, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Merge requirement checklist
CHANGELOG.mdfiles updated for non-trivial changesChanges in public API reviewed (if applicable)