[API] Refactor slicing code#7446
Merged
martincostello merged 2 commits intoJun 23, 2026
Merged
Conversation
Use `IsEmpty` and consume the slice rather than tracking an index.
martincostello
marked this pull request as ready for review
June 23, 2026 07:54
Contributor
There was a problem hiding this comment.
Pull request overview
Refactors the tracestate parsing loop in TraceContextPropagator to consume the ReadOnlySpan<char> as it is parsed (using IsEmpty and slicing), instead of tracking a separate index. This is part of the API-layer W3C Trace Context propagation logic.
Changes:
- Updated the
TryExtractMultipleTracestateloop to parse comma-separated members by advancing the span (tracestate = tracestate.Slice(...)) until empty. - Simplified slice/index usage by calling
IndexOf(',')on the remaining span rather than slicing from an externalbeginoffset.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7446 +/- ##
=======================================
Coverage 89.98% 89.98%
=======================================
Files 277 277
Lines 14624 14623 -1
=======================================
Hits 13159 13159
+ Misses 1465 1464 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Kielek
approved these changes
Jun 23, 2026
Assign directly to an empty span instead of slicing away the whole span.
martincostello
enabled auto-merge
June 23, 2026 08:23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Noticed while working on #7433.
Changes
Use
IsEmptyand consume the slice rather than tracking an index.Merge requirement checklist
Unit tests added/updatedAppropriateCHANGELOG.mdfiles updated for non-trivial changesChanges in public API reviewed (if applicable)