-
Notifications
You must be signed in to change notification settings - Fork 890
[Metrics] Exclude list for tags on Metrics #7373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 12 commits
Commits
Show all changes
29 commits
Select commit
Hold shift + click to select a range
ef01b16
Add support for excluding tag keys in MetricStreamConfiguration and r…
nabutabu d123bfb
Add support for excluding tag keys in Exemplar and related classes
nabutabu 6a9f7f7
Add unit test for excluding tag keys in exemplars
nabutabu 276c3e2
Remove commented explanations for include and exclude modes in ReadOn…
nabutabu b485e01
lint
nabutabu c74635c
Merge branch 'main' into exclude-tags-1
nabutabu d7edccf
Refactor ExemplarReservoirFactory property to improve clarity and mai…
nabutabu 40d0a8f
Empty tag keys is a valid configuration
nabutabu 3621029
Merge branch 'main' into exclude-tags-1
nabutabu 28d39d7
Merge branch 'main' into exclude-tags-1
nabutabu b367657
Changelog updated
nabutabu c75dcca
lint
nabutabu 06f0ba9
Update src/OpenTelemetry/Metrics/AggregatorStore.cs
nabutabu eb13d51
Rename ExcludedTagKeysInteresting to ExcludedTagKeys
nabutabu b2ff4fa
remove multiple access of tags[n]
nabutabu 56ce766
Merge branch 'main' into exclude-tags-1
nabutabu 2bb5367
Update src/OpenTelemetry/Metrics/View/MetricStreamConfiguration.cs
nabutabu 7a05799
Clarify TagKeys order sensitivity behavior
nabutabu a29f584
clarify default behavior
nabutabu 185edda
ExcludedTagKeys condition update and update MetricViewTests to use em…
nabutabu 43fe3fa
Merge branch 'main' into exclude-tags-1
nabutabu 99d7c4b
typo
nabutabu 636f71b
changelog wording changed
nabutabu c2dffca
Merge branch 'main' into exclude-tags-1
nabutabu f69791c
Update MetricsViewBenchmarks for new benchmarks on exclude tag keys
nabutabu e4af536
Merge branch 'main' into exclude-tags-1
nabutabu 6010cdd
direct feedback
Kielek f544cdd
Merge branch 'main' into exclude-tags-1
Kielek b7893ac
Merge branch 'main' into exclude-tags-1
nabutabu File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| OpenTelemetry.Metrics.MetricStreamConfiguration.ExcludedTagKeys.get -> string![]? | ||
| OpenTelemetry.Metrics.MetricStreamConfiguration.ExcludedTagKeys.set -> void |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.