Skip to content

[tests] add Xunit namespaces to global usings#7365

Merged
Kielek merged 2 commits into
open-telemetry:mainfrom
Kielek:xunit-global
Jun 3, 2026
Merged

[tests] add Xunit namespaces to global usings#7365
Kielek merged 2 commits into
open-telemetry:mainfrom
Kielek:xunit-global

Conversation

@Kielek

@Kielek Kielek commented Jun 3, 2026

Copy link
Copy Markdown
Member

Inspired by https://github.com/open-telemetry/opentelemetry-dotnet-instrumentation/pull/5133/changes#diff-af5b00be86cfd4b9af22d05535dc0c179aaa41549a0e6a978db498a55ca28075R17-R21 and new pragmas #7354

Changes

[tests] add Xunit namescpaces to global usings
Verify.XUnit brings this by default, so part of the test project does not need this. Enabling this globally.

Merge requirement checklist

  • CONTRIBUTING guidelines followed (license requirements, nullable enabled, static analysis, etc.)
  • Unit tests added/updated
  • [ ] Appropriate CHANGELOG.md files updated for non-trivial changes
  • [ ] Changes in public API reviewed (if applicable)

@Kielek Kielek requested a review from a team as a code owner June 3, 2026 14:48
@Kielek Kielek changed the title [tests] add Xunit namescpaces to global usings [tests] add Xunit namespaces to global usings Jun 3, 2026
@github-actions github-actions Bot added pkg:OpenTelemetry.Api.ProviderBuilderExtensions Issues related to OpenTelemetry.Api.ProviderBuilderExtensions NuGet package pkg:OpenTelemetry.Api Issues related to OpenTelemetry.Api NuGet package pkg:OpenTelemetry.Exporter.Console Issues related to OpenTelemetry.Exporter.Console NuGet package pkg:OpenTelemetry.Exporter.OpenTelemetryProtocol Issues related to OpenTelemetry.Exporter.OpenTelemetryProtocol NuGet package pkg:OpenTelemetry.Exporter.Prometheus.AspNetCore Issues related to OpenTelemetry.Exporter.Prometheus.AspNetCore NuGet package pkg:OpenTelemetry.Exporter.Prometheus.HttpListener Issues related to OpenTelemetry.Exporter.Prometheus.HttpListener NuGet package pkg:OpenTelemetry.Exporter.Zipkin Issues related to OpenTelemetry.Exporter.Zipkin NuGet package pkg:OpenTelemetry.Extensions.Hosting Issues related to OpenTelemetry.Extensions.Hosting NuGet package pkg:OpenTelemetry.Extensions.Propagators Issues related to OpenTelemetry.Extensions.Propagators NuGet package pkg:OpenTelemetry.Shims.OpenTracing Issues related to OpenTelemetry.Shims.OpenTracing NuGet package pkg:OpenTelemetry Issues related to OpenTelemetry NuGet package labels Jun 3, 2026
@codecov

codecov Bot commented Jun 3, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.00%. Comparing base (e63db52) to head (6b65085).
✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #7365      +/-   ##
==========================================
- Coverage   90.00%   90.00%   -0.01%     
==========================================
  Files         276      276              
  Lines       14283    14283              
==========================================
- Hits        12856    12855       -1     
- Misses       1427     1428       +1     
Flag Coverage Δ
unittests-Project-Experimental 89.92% <ø> (-0.06%) ⬇️
unittests-Project-Stable 89.93% <ø> (+0.27%) ⬆️
unittests-Solution 89.99% <ø> (+0.03%) ⬆️
unittests-UnstableCoreLibraries-Experimental 48.62% <ø> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 2 files with indirect coverage changes

@Kielek Kielek added this pull request to the merge queue Jun 3, 2026
Merged via the queue into open-telemetry:main with commit aee11ba Jun 3, 2026
99 checks passed
@Kielek Kielek deleted the xunit-global branch June 3, 2026 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pkg:OpenTelemetry.Api.ProviderBuilderExtensions Issues related to OpenTelemetry.Api.ProviderBuilderExtensions NuGet package pkg:OpenTelemetry.Api Issues related to OpenTelemetry.Api NuGet package pkg:OpenTelemetry.Exporter.Console Issues related to OpenTelemetry.Exporter.Console NuGet package pkg:OpenTelemetry.Exporter.OpenTelemetryProtocol Issues related to OpenTelemetry.Exporter.OpenTelemetryProtocol NuGet package pkg:OpenTelemetry.Exporter.Prometheus.AspNetCore Issues related to OpenTelemetry.Exporter.Prometheus.AspNetCore NuGet package pkg:OpenTelemetry.Exporter.Prometheus.HttpListener Issues related to OpenTelemetry.Exporter.Prometheus.HttpListener NuGet package pkg:OpenTelemetry.Exporter.Zipkin Issues related to OpenTelemetry.Exporter.Zipkin NuGet package pkg:OpenTelemetry.Extensions.Hosting Issues related to OpenTelemetry.Extensions.Hosting NuGet package pkg:OpenTelemetry.Extensions.Propagators Issues related to OpenTelemetry.Extensions.Propagators NuGet package pkg:OpenTelemetry.Shims.OpenTracing Issues related to OpenTelemetry.Shims.OpenTracing NuGet package pkg:OpenTelemetry Issues related to OpenTelemetry NuGet package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants