[Metrics] Resolve accumulated TODOs in SDK core by nimanikoo · Pull Request #7277 · open-telemetry/opentelemetry-dotnet

nimanikoo · 2026-05-09T12:39:30Z

Hey everyone! 👋 I was going through the codebase and spotted a few TODOs that looked straightforward to fix, so I went ahead and took care of them. Thanks for maintaining such a great project and for everything you do for the open source community 🙏

Changes

Clears four long-standing TODO comments in the metrics SDK. Each change is small and self-contained; they are grouped together because they all touch the same area and share the same low risk profile.

Exception safety for custom ExemplarReservoir
MetricPoint.UpdateExemplar called ExemplarReservoir.Offer with no protection. Any exception from a user-supplied reservoir would propagate up and corrupt the measurement path. The fix wraps the call in a try/catch and emits a new Warning-level EventSource event (#57, ExemplarReservoirException). To preserve AggressiveInlining on the hot path, the guard (if (offerExemplar)) stays inlined in UpdateExemplar while the offer + exception handling moves into a non-inlined OfferExemplarSafe helper.

Diagnostic log in MeasurementsCompleted
When MeasurementsCompleted receives a state that isn't a MetricState, it now logs a Verbose-level MeterProviderSdkEvent before returning — consistent with MeasurementRecordedLong and MeasurementRecordedDouble in the same file.

Log unknown instrument type in temporality preference
MonotonicDeltaTemporalityPreferenceFunc had a silent _ => AggregationTemporality.Delta default. It is now a block lambda that emits a Verbose log when an unrecognized instrument type hits that arm. Return behavior is unchanged.

TrimExcess() after AddMetricWithViews
The metrics list is pre-allocated to the maximum view count, but views can be skipped for several reasons (invalid name, existing metric, Drop config, limit exceeded). TrimExcess() is now called after the lock is released to reclaim unused capacity without extending lock hold time.

Merge requirement checklist

CONTRIBUTING guidelines followed (license requirements, nullable enabled, static analysis, etc.)
Unit tests added/updated
Changes in public API reviewed (if applicable)
Appropriate CHANGELOG.md files updated for non-trivial changes

Wrap ExemplarReservoir.Offer in try/catch so a buggy custom reservoir can't silently crash the measurement path. Surfaces the error as a new Warning event (open-telemetry#57). Log a Verbose diagnostic in MeasurementsCompleted when the state object isn't a MetricState, consistent with every other callback in the file. Log unknown instrument types that fall through to the default case in MonotonicDeltaTemporalityPreferenceFunc. Call TrimExcess() after releasing the creation lock in AddMetricWithViews to reclaim wasted list capacity

Copilot

Pull request overview

Resolves several long-standing TODOs in the metrics SDK core by improving exception safety around exemplars, adding missing verbose diagnostics, and reducing unnecessary allocations from over-provisioned metric lists.

Changes:

Wraps user-supplied ExemplarReservoir.Offer calls with exception handling and introduces a new Warning-level EventSource event for failures.
Adds verbose diagnostics for unexpected state in MeasurementsCompleted and for unrecognized instrument types in temporality preference selection.
Calls TrimExcess() on the metrics list created in AddMetricWithViews after releasing the lock to reclaim unused capacity.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
src/OpenTelemetry/Metrics/Reader/MetricReaderExt.cs	Trims preallocated metrics list capacity after view processing completes.
src/OpenTelemetry/Metrics/Reader/MetricReader.cs	Adds verbose log when temporality preference sees an unexpected instrument type.
src/OpenTelemetry/Metrics/MetricPoint/MetricPoint.cs	Adds exception-safe exemplar offering via helper methods.
src/OpenTelemetry/Metrics/MeterProviderSdk.cs	Adds verbose log when `MeasurementsCompleted` receives an unexpected state type.
src/OpenTelemetry/Internal/OpenTelemetrySdkEventSource.cs	Adds new EventId 57 warning event for exemplar reservoir offer exceptions.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

codecov · 2026-05-09T12:50:44Z

Codecov Report

❌ Patch coverage is 89.47368% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.03%. Comparing base (2e084dc) to head (2200384).
⚠️ Report is 22 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines	Patch %	Lines
src/OpenTelemetry/Metrics/Reader/MetricReader.cs	84.21%	3 Missing ⚠️
src/OpenTelemetry/Metrics/MeterProviderSdk.cs	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #7277      +/-   ##
==========================================
- Coverage   90.03%   90.03%   -0.01%     
==========================================
  Files         276      276              
  Lines       14218    14244      +26     
==========================================
+ Hits        12801    12824      +23     
- Misses       1417     1420       +3

Flag	Coverage Δ
unittests-Project-Experimental	`89.98% <89.47%> (+0.08%)`	⬆️
unittests-Project-Stable	`89.89% <89.47%> (-0.07%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
...nTelemetry/Internal/OpenTelemetrySdkEventSource.cs	`64.44% <100.00%> (+1.65%)`	⬆️
...c/OpenTelemetry/Metrics/MetricPoint/MetricPoint.cs	`94.93% <100.00%> (+0.15%)`	⬆️
...rc/OpenTelemetry/Metrics/Reader/MetricReaderExt.cs	`92.12% <100.00%> (+0.06%)`	⬆️
src/OpenTelemetry/Metrics/MeterProviderSdk.cs	`94.19% <0.00%> (-0.40%)`	⬇️
src/OpenTelemetry/Metrics/Reader/MetricReader.cs	`91.08% <84.21%> (-0.87%)`	⬇️

... and 2 files with indirect coverage changes

martincostello

Also please review the Copilot review comments.

…dling

rajkumar-rangaraj · 2026-05-18T19:15:06Z

copilot feedback

Code Review — PR #7277 [Metrics] Resolve accumulated TODOs in SDK core

Consensus findings (both Opus 4.7 + Opus 4.6 agreed) — real issues

Per-measurement Warning log spam from OfferExemplarSafe 🟡 Medium
A buggy user ExemplarReservoir.Offer will raise EventSource event remove options from end and make SpanContext specific class #57 (Warning) on every measurement — potentially millions per second on the hot path. Existing user-callback handlers in AggregatorStore.cs swallow silently for this exact reason. Suggested fix: log-once-per-reservoir-instance (track a bool on the wrapper), or drop the level to Verbose.
TrimExcess() is wasted (and arguably harmful) 🟡 Medium
Opus 4.7 gave the strongest evidence: the returned metrics list is immediately consumed by MetricState.BuildForMetricList which calls metrics.ToArray() — the list itself is then unreachable. TrimExcess just allocates a new backing array that's thrown away. Opus 4.6 separately noted the same allocation cost. Revert this change or remove the call. The original TODO's premise ("memory wasted until Meter disposed") was incorrect.

Where the models disagreed — I verified by reading the code

MeasurementsCompleted severity inconsistency 🟡 Medium — Opus 4.6 correct
Opus 4.7 said the PR "mirrors the surrounding pattern" at Verbose. It does not. I checked MeterProviderSdk.cs lines 205–222: the sibling methods MeasurementRecordedLong/Double use OpenTelemetrySdkEventSource.Log.MeasurementDropped(..., "SDK internal error occurred.", "Contact SDK owners.") at Warning level for the identical state is not MetricState check. The PR uses MeterProviderSdkEvent at Verbose, making a real SDK bug effectively invisible in production. Should match siblings (MeasurementDropped, Warning).

Unique to Opus 4.7

Missing CHANGELOG entry 🟡 Medium
The exception-safety change is user-observable: previously, an exception in a custom reservoir bubbled out of Counter.Add/Histogram.Record; now it's swallowed and logged. Needs an Unreleased bullet under src/OpenTelemetry/CHANGELOG.md referencing [Metrics] Resolve accumulated TODOs in SDK core #7277.

Plus useful verifications: event id 57 is unique; [MethodImpl(NoInlining)] is present (not relying on JIT); MonotonicDeltaTemporalityPreferenceFunc outer lambda remains static with no closure allocation; OpenTelemetrySdkEventSource is internal (no .publicApi/ update needed); the PR does include unit tests with ThrowingExemplarReservoir (correcting a wrong premise in my prompt).

Model comparison notes

Opus
4.7 (118s): More thorough, did extra verifications, caught the CHANGELOG gap, but got the MeasurementsCompleted severity wrong (claimed it mirrored siblings — it doesn't).
Opus
4.6 (90s): Faster, correctly flagged the severity inconsistency, but missed the CHANGELOG, didn't verify event id / NoInlining / closure-safety, and didn't notice the PR has tests.
Both independently converged on the two most important issues (log spam + wasted TrimExcess), which boosts confidence.

Recommended actions for the PR

Add log-rate-limiting (or drop to Verbose) for ExemplarReservoirException.
Remove the TrimExcess() call — it provides no benefit.
Change MeasurementsCompleted log to use MeasurementDropped at Warning, matching siblings.
Add a CHANGELOG entry describing the new exception-safety behavior.

…and logging - Drop ExemplarReservoirException event from Warning to Verbose — a throwing reservoir fires on every measurement, making Warning level impractical on hot paths where exemplar capture is best-effort anyway - Remove TrimExcess() from AddMetricWithViews — the caller immediately calls .ToArray() on the returned list, so the trim just allocates a backing array that is discarded on the next line - Align MeasurementsCompleted error logging with its siblings MeasurementRecordedLong/Double, which use MeasurementDropped at Warning for the same state mismatch condition - Add CHANGELOG entry for the exception-safety behaviour introduced by OfferExemplarSafe, which is a user-observable contract change

nimanikoo · 2026-05-21T18:56:09Z

Thanks for the thorough review @rajkumar-rangaraj
all four points addressed:

ExemplarReservoirException log level
Dropped event #57 from Warning to Verbose. You're right that exemplar capture is best-effort and a misbehaving reservoir shouldn't pollute the warning stream on every measurement. The Verbose level keeps it observable for anyone actively debugging without becoming noise in production.

TrimExcess()
Removed. I missed that BuildForMetricList calls .ToArray() immediately, which makes the trim pointless it just allocates a backing array that's abandoned on the next line. Good catch.

MeasurementsCompleted severity
Fixed to use MeasurementDropped at Warning, same as MeasurementRecordedLong and MeasurementRecordedDouble. The original MeterProviderSdkEvent call was at Verbose, which would have made a real SDK-state bug completely invisible in production. Should have matched siblings from the start.

CHANGELOG
Added an entry under Unreleased. The swallow-instead-of-propagate behavior on ExemplarReservoir.Offer is user-visible anyone relying on the exception bubbling out of Counter.Add to detect a broken reservoir would be silently broken without this note.

f55b873

I'm really excited to see this merged and looking forward to contributing more to the project in the future.

martincostello · 2026-05-23T14:50:16Z

/easycla

nimanikoo · 2026-06-02T10:17:31Z

Hi @rajkumar-rangaraj
Could someone please take a look at this PR when possible?
It has been pending for a while and I’d really appreciate a review. Thanks 🙏

….0 (#1201) Updated [OpenTelemetry.Exporter.OpenTelemetryProtocol](https://github.com/open-telemetry/opentelemetry-dotnet) from 1.15.3 to 1.16.0. <details> <summary>Release notes</summary> _Sourced from [OpenTelemetry.Exporter.OpenTelemetryProtocol's releases](https://github.com/open-telemetry/opentelemetry-dotnet/releases)._ ## 1.16.0 For highlights and announcements pertaining to this release see: [Release Notes > 1.16.0](https://github.com/open-telemetry/opentelemetry-dotnet/blob/main/RELEASENOTES.md#1160). The following changes are from the previous release [1.16.0-rc.1](https://github.com/open-telemetry/opentelemetry-dotnet/releases/tag/core-1.16.0-rc.1). * NuGet: [OpenTelemetry v1.16.0](https://www.nuget.org/packages/OpenTelemetry/1.16.0) No notable changes. See [CHANGELOG](https://github.com/open-telemetry/opentelemetry-dotnet/blob/core-1.16.0/src/OpenTelemetry/CHANGELOG.md) for details. * NuGet: [OpenTelemetry.Api v1.16.0](https://www.nuget.org/packages/OpenTelemetry.Api/1.16.0) No notable changes. See [CHANGELOG](https://github.com/open-telemetry/opentelemetry-dotnet/blob/core-1.16.0/src/OpenTelemetry.Api/CHANGELOG.md) for details. * NuGet: [OpenTelemetry.Api.ProviderBuilderExtensions v1.16.0](https://www.nuget.org/packages/OpenTelemetry.Api.ProviderBuilderExtensions/1.16.0) No notable changes. See [CHANGELOG](https://github.com/open-telemetry/opentelemetry-dotnet/blob/core-1.16.0/src/OpenTelemetry.Api.ProviderBuilderExtensions/CHANGELOG.md) for details. * NuGet: [OpenTelemetry.Exporter.Console v1.16.0](https://www.nuget.org/packages/OpenTelemetry.Exporter.Console/1.16.0) No notable changes. See [CHANGELOG](https://github.com/open-telemetry/opentelemetry-dotnet/blob/core-1.16.0/src/OpenTelemetry.Exporter.Console/CHANGELOG.md) for details. * NuGet: [OpenTelemetry.Exporter.InMemory v1.16.0](https://www.nuget.org/packages/OpenTelemetry.Exporter.InMemory/1.16.0) No notable changes. See [CHANGELOG](https://github.com/open-telemetry/opentelemetry-dotnet/blob/core-1.16.0/src/OpenTelemetry.Exporter.InMemory/CHANGELOG.md) for details. * NuGet: [OpenTelemetry.Exporter.OpenTelemetryProtocol v1.16.0](https://www.nuget.org/packages/OpenTelemetry.Exporter.OpenTelemetryProtocol/1.16.0) No notable changes. See [CHANGELOG](https://github.com/open-telemetry/opentelemetry-dotnet/blob/core-1.16.0/src/OpenTelemetry.Exporter.OpenTelemetryProtocol/CHANGELOG.md) for details. * NuGet: [OpenTelemetry.Exporter.Zipkin v1.16.0](https://www.nuget.org/packages/OpenTelemetry.Exporter.Zipkin/1.16.0) No notable changes. See [CHANGELOG](https://github.com/open-telemetry/opentelemetry-dotnet/blob/core-1.16.0/src/OpenTelemetry.Exporter.Zipkin/CHANGELOG.md) for details. * NuGet: [OpenTelemetry.Extensions.Hosting v1.16.0](https://www.nuget.org/packages/OpenTelemetry.Extensions.Hosting/1.16.0) No notable changes. ... (truncated) ## 1.16.0-rc.1 The following changes are from the previous release [1.15.3](https://github.com/open-telemetry/opentelemetry-dotnet/releases/tag/core-1.15.3). * NuGet: [OpenTelemetry v1.16.0-rc.1](https://www.nuget.org/packages/OpenTelemetry/1.16.0-rc.1) * Stop validating View-provided metric stream `Name` against the instrument name syntax, per [spec clarification](open-telemetry/opentelemetry-specification#5094). ([#7300](open-telemetry/opentelemetry-dotnet#7300)) * Fix incorrect validation of `OTEL_BSP_*` and `OTEL_BLRP_*` environment variables. ([#7187](open-telemetry/opentelemetry-dotnet#7187)) * Fix observable instrument callbacks running once per reader instead of once per collection cycle. ([#7188](open-telemetry/opentelemetry-dotnet#7188)) * Added exception safety for user-supplied `ExemplarReservoir` implementations. Exceptions thrown from `Offer` are now caught and logged rather than propagating out of `Counter.Add`/`Histogram.Record`. ([#7277](open-telemetry/opentelemetry-dotnet#7277)) * Update `OpenTelemetrySdkEventSource` to support the W3C randomness flag. ([#7301](open-telemetry/opentelemetry-dotnet#7301)) * Added `ObservedTimestamp` property to `LogRecord`. ([#6979](open-telemetry/opentelemetry-dotnet#6979)) * **Breaking Change** Explicit histogram boundaries no longer allow more than 10 million values. ([#7165](open-telemetry/opentelemetry-dotnet#7165)) * Fixed a circular reference which could cause a `LoggerProvider` to fail to resolve when one of its dependencies depends on `ILogger` or `ILoggerFactory`. As part of this fix the `LoggerProvider` resolved from dependency injection is now created lazily when the first logger is created rather than when `ILoggerProvider` or `ILoggerFactory` is resolved. A consequence is that any invalid configuration now surfaces when the first log record is written instead of when the logging services are resolved. ([#7308](open-telemetry/opentelemetry-dotnet#7308)) See [CHANGELOG](https://github.com/open-telemetry/opentelemetry-dotnet/blob/core-1.16.0-rc.1/src/OpenTelemetry/CHANGELOG.md) for details. * NuGet: [OpenTelemetry.Api v1.16.0-rc.1](https://www.nuget.org/packages/OpenTelemetry.Api/1.16.0-rc.1) * **Experimental (pre-release builds only):** Add support for using environment variables as context propagation carriers. ([#7174](open-telemetry/opentelemetry-dotnet#7174)) * Fix `BaggagePropagator` to correctly follow Key and Value Encoding rules as per ... (truncated) ## 1.16.0-beta.1 The following changes are from the previous release [1.15.3-beta.1](https://github.com/open-telemetry/opentelemetry-dotnet/releases/tag/coreunstable-1.15.3-beta.1). * NuGet: [OpenTelemetry.Exporter.Prometheus.AspNetCore v1.16.0-beta.1](https://www.nuget.org/packages/OpenTelemetry.Exporter.Prometheus.AspNetCore/1.16.0-beta.1) * Fixed scrape response cache freshness using monotonic time so it is not affected by NTP system clock adjustments. ([#7253](open-telemetry/opentelemetry-dotnet#7253)) * **Breaking Change** Removed `DisableTimestamp` property from `PrometheusAspNetCoreOptions`. ([#7176](open-telemetry/opentelemetry-dotnet#7176)) * Fixed the serialization of `NaN`, `PositiveInfinity`, and `NegativeInfinity` values in Prometheus metrics to be compliant with the specification. ([#7179](open-telemetry/opentelemetry-dotnet#7179)) * Fixed loss of precision when serializing `double` and `float` values in Prometheus metrics to be compliant with the specification by using 17 significant digits to represent such values. ([#7179](open-telemetry/opentelemetry-dotnet#7179)) * Fix non-ASCII characters in metric names and unit strings not being sanitized correctly during Prometheus serialization. ([#7184](open-telemetry/opentelemetry-dotnet#7184)) * Fix case where reader tracking could be reset while readers were still active. ([#7190](open-telemetry/opentelemetry-dotnet#7190)) * Improve `Accept` header handling for format negotiation so OpenMetrics is selected correctly by considering whitespace and `q` weights. ([#7208](open-telemetry/opentelemetry-dotnet#7208)) * Emit OpenMetrics exemplars for counters and histogram buckets. ([#7222](open-telemetry/opentelemetry-dotnet#7222)) * Fix incorrect handling of untyped metrics when using OpenMetrics format. ([#7219](open-telemetry/opentelemetry-dotnet#7219)) * Fix Prometheus/OpenMetrics serialization to emit metric and label names containing `_` instead of dropping them and prefixing leading digits. Invalid characters are replaced with `_` instead of being dropped. ([#7209](open-telemetry/opentelemetry-dotnet#7209)) * Add `escaping=underscores` to the `Accept` header handling for content negotiation so OpenMetrics are handled correctly. ([#7209](open-telemetry/opentelemetry-dotnet#7209)) * Omit histogram `_sum` and `_count` in OpenMetrics when negative bucket thresholds are present. ([#7221](open-telemetry/opentelemetry-dotnet#7221)) ... (truncated) Commits viewable in [compare view](open-telemetry/opentelemetry-dotnet@core-1.15.3...core-1.16.0). </details> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=OpenTelemetry.Exporter.OpenTelemetryProtocol&package-manager=nuget&previous-version=1.15.3&new-version=1.16.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Copilot AI review requested due to automatic review settings May 9, 2026 12:39

nimanikoo requested a review from a team as a code owner May 9, 2026 12:39

github-actions Bot added the pkg:OpenTelemetry Issues related to OpenTelemetry NuGet package label May 9, 2026

Copilot started reviewing on behalf of nimanikoo May 9, 2026 12:40 View session

Merge branch 'main' into fix/resolve-simple-todos-metrics-sdk

6eedad8

Copilot AI reviewed May 9, 2026

View reviewed changes

Comment thread src/OpenTelemetry/Metrics/MetricPoint/MetricPoint.cs

Comment thread src/OpenTelemetry/Metrics/MetricPoint/MetricPoint.cs

Comment thread src/OpenTelemetry/Metrics/Reader/MetricReader.cs Outdated

martincostello reviewed May 11, 2026

View reviewed changes

Comment thread src/OpenTelemetry/Metrics/Reader/MetricReader.cs

nimanikoo added 4 commits May 14, 2026 13:11

Merge branch 'main' into fix/resolve-simple-todos-metrics-sdk

9991f3e

[Metrics] Add NoInlining to OfferExemplarSafe to enforce JIT boundary

16be5bb

Rollback to orginal code

f36fc53

Fixup the reader event for consistency

284dfc0

nimanikoo requested a review from martincostello May 14, 2026 10:24

martincostello reviewed May 14, 2026

View reviewed changes

Comment thread src/OpenTelemetry/Metrics/MetricPoint/MetricPoint.cs

test(metrics): add coverage for ExemplarReservoir.Offer exception han…

dda50a2

…dling

martincostello approved these changes May 15, 2026

View reviewed changes

Comment thread test/OpenTelemetry.Tests/Metrics/MetricExemplarTests.cs Outdated

test(metrics) : change code style on ThrowingExemplarReservoir

4e4b285

nimanikoo added 3 commits May 19, 2026 15:17

Merge branch 'main' into fix/resolve-simple-todos-metrics-sdk

2e395a7

Merge branch 'main' into fix/resolve-simple-todos-metrics-sdk

04b0e5a

Merge branch 'main' into fix/resolve-simple-todos-metrics-sdk

2742781

Kielek requested a review from rajkumar-rangaraj May 25, 2026 04:43

nimanikoo added 3 commits May 25, 2026 11:36

Merge branch 'main' into fix/resolve-simple-todos-metrics-sdk

ed28e1a

Merge branch 'main' into fix/resolve-simple-todos-metrics-sdk

6be51af

Merge branch 'main' into fix/resolve-simple-todos-metrics-sdk

2200384

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Metrics] Resolve accumulated TODOs in SDK core#7277

[Metrics] Resolve accumulated TODOs in SDK core#7277
martincostello merged 15 commits into
open-telemetry:mainfrom
nimanikoo:fix/resolve-simple-todos-metrics-sdk

nimanikoo commented May 9, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

codecov Bot commented May 9, 2026 •

edited

Loading

Uh oh!

martincostello left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

rajkumar-rangaraj commented May 18, 2026

Uh oh!

nimanikoo commented May 21, 2026

Uh oh!

martincostello commented May 23, 2026

Uh oh!

nimanikoo commented Jun 2, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

nimanikoo commented May 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes

Merge requirement checklist

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

codecov Bot commented May 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

martincostello left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

rajkumar-rangaraj commented May 18, 2026

Uh oh!

nimanikoo commented May 21, 2026

Uh oh!

martincostello commented May 23, 2026

Uh oh!

nimanikoo commented Jun 2, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

nimanikoo commented May 9, 2026 •

edited

Loading

codecov Bot commented May 9, 2026 •

edited

Loading