-
Notifications
You must be signed in to change notification settings - Fork 893
[Prometheus.AspNetCore] Support GZip #7274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+111
−8
Merged
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
0f018e2
[Exporter.Prometheus] Observe request timeout
martincostello 9bdc57a
[Exporter.Prometheus] Update CHANGELOGs
martincostello b7ff4db
[Exporter.Prometheus] Address feedback
martincostello 5e90244
[Prometheus.AspNetCore] Extend integration tests
martincostello ca448e5
[Prometheus.AspNetCore] Address review comments
martincostello af91589
[Prometheus.AspNetCore] Support GZip
martincostello 05b3a83
[Prometheus.AspNetCore] Update CompressionLevel
martincostello 50b75f2
Merge branch 'main' into gh-7213
martincostello 60aad7a
Merge branch 'main' into gh-7213
martincostello bf2ed3a
[Prometheus.AspNetCore] Fix tests
martincostello c6f5522
Merge branch 'main' into gh-7213
martincostello c04e031
[Prometheus.AspNetCore] Remove redundant method
martincostello d003819
[Prometheus.AspNetCore] Address feedback
martincostello a98605d
[Prometheus.AspNetCore] Fix CHANGELOG
martincostello cc4019e
Merge branch 'main' into gh-7213
martincostello 844990b
Merge branch 'main' into gh-7213
martincostello f848e61
Merge branch 'main' into gh-7213
martincostello 2cfffe0
Ensure Prometheus scrape responses vary by encoding
Kielek d2e5ec6
Merge branch 'main' into gh-7213
martincostello File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AspNetCore has no synchronisation context so
ConfigureAwait(false)has no effect.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
True, I would consider keeping this calls just in case we need to share with httplistener similar code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At the moment the code reuse is one way from HttpListener to AspNetCore, so I don't think we need to worry about that in practice as if it needs to be shared it'll go in the other project which doesn't supress CA2007.