[Exporter.Prometheus] Remove DisableTimestamp

src/OpenTelemetry.Exporter.Prometheus.AspNetCore/.publicApi/PublicAPI.Unshipped.txt

@@ -1,8 +1,6 @@
 Microsoft.AspNetCore.Builder.PrometheusExporterApplicationBuilderExtensions
 Microsoft.AspNetCore.Builder.PrometheusExporterEndpointRouteBuilderExtensions
 OpenTelemetry.Exporter.PrometheusAspNetCoreOptions
-OpenTelemetry.Exporter.PrometheusAspNetCoreOptions.DisableTimestamp.get -> bool
-OpenTelemetry.Exporter.PrometheusAspNetCoreOptions.DisableTimestamp.set -> void
 OpenTelemetry.Exporter.PrometheusAspNetCoreOptions.DisableTotalNameSuffixForCounters.get -> bool
 OpenTelemetry.Exporter.PrometheusAspNetCoreOptions.DisableTotalNameSuffixForCounters.set -> void
 OpenTelemetry.Exporter.PrometheusAspNetCoreOptions.PrometheusAspNetCoreOptions() -> void

src/OpenTelemetry.Exporter.Prometheus.AspNetCore/CHANGELOG.md

@@ -7,6 +7,10 @@ Notes](../../RELEASENOTES.md).
 
 ## Unreleased
 
+* **Breaking Change** Removed `DisableTimestamp` property from
+  `PrometheusAspNetCoreOptions`.
+  ([#7176](https://github.com/open-telemetry/opentelemetry-dotnet/pull/7176))
+
 ## 1.15.3-beta.1
 
 Released 2026-Apr-21

src/OpenTelemetry.Exporter.Prometheus.AspNetCore/PrometheusAspNetCoreOptions.cs

@@ -38,14 +38,5 @@ public int ScrapeResponseCacheDurationMilliseconds
         set => this.ExporterOptions.ScrapeResponseCacheDurationMilliseconds = value;
     }
 
-    /// <summary>
-    /// Gets or sets a value indicating whether timestamps should be disabled. Default value: <see langword="false"/>.
-    /// </summary>
-    public bool DisableTimestamp
-    {
-        get => this.ExporterOptions.DisableTimestamp;
-        set => this.ExporterOptions.DisableTimestamp = value;
-    }
-
     internal PrometheusExporterOptions ExporterOptions { get; } = new();
 }

src/OpenTelemetry.Exporter.Prometheus.HttpListener/.publicApi/PublicAPI.Unshipped.txt

@@ -3,8 +3,6 @@ OpenTelemetry.Exporter.PrometheusHttpListenerOptions.Host.get -> string!
 OpenTelemetry.Exporter.PrometheusHttpListenerOptions.Host.set -> void
 OpenTelemetry.Exporter.PrometheusHttpListenerOptions.Port.get -> int
 OpenTelemetry.Exporter.PrometheusHttpListenerOptions.Port.set -> void
-OpenTelemetry.Exporter.PrometheusHttpListenerOptions.DisableTimestamp.get -> bool
-OpenTelemetry.Exporter.PrometheusHttpListenerOptions.DisableTimestamp.set -> void
 OpenTelemetry.Exporter.PrometheusHttpListenerOptions.DisableTotalNameSuffixForCounters.get -> bool
 OpenTelemetry.Exporter.PrometheusHttpListenerOptions.DisableTotalNameSuffixForCounters.set -> void
 OpenTelemetry.Exporter.PrometheusHttpListenerOptions.UriPrefixes.get -> System.Collections.Generic.IReadOnlyCollection<string!>!

src/OpenTelemetry.Exporter.Prometheus.HttpListener/CHANGELOG.md

@@ -11,7 +11,11 @@ Notes](../../RELEASENOTES.md).
   for configuring the HTTP listener endpoint. The
   `PrometheusHttpListenerOptions.UriPrefixes` property is now obsolete and
   will be removed in the stable release.
-  ([#7107](https://github.com/open-telemetry/opentelemetry-dotnet/pull/7114))
+  ([#7114](https://github.com/open-telemetry/opentelemetry-dotnet/pull/7114))
+
+* **Breaking Change** Removed `DisableTimestamp` property from
+  `PrometheusHttpListenerOptions`.
+  ([#7176](https://github.com/open-telemetry/opentelemetry-dotnet/pull/7176))
 
 ## 1.15.3-beta.1
 

src/OpenTelemetry.Exporter.Prometheus.HttpListener/Internal/PrometheusCollectionManager.cs

@@ -276,8 +276,7 @@ private ExportResult OnCollect(in Batch<Metric> metrics)
                             cursor,
                             metric,
                             this.GetPrometheusMetric(metric),
-                            this.exporter.OpenMetricsRequested,
-                            this.exporter.DisableTimestamp);
+                            this.exporter.OpenMetricsRequested);
 
                         break;
                     }

src/OpenTelemetry.Exporter.Prometheus.HttpListener/Internal/PrometheusExporter.cs

@@ -25,7 +25,6 @@ public PrometheusExporter(PrometheusExporterOptions options)
 
         this.ScrapeResponseCacheDurationMilliseconds = options.ScrapeResponseCacheDurationMilliseconds;
         this.DisableTotalNameSuffixForCounters = options.DisableTotalNameSuffixForCounters;
-        this.DisableTimestamp = options.DisableTimestamp;
 
         this.CollectionManager = new PrometheusCollectionManager(this);
     }
@@ -49,8 +48,6 @@ public PrometheusExporter(PrometheusExporterOptions options)
 
     internal bool OpenMetricsRequested { get; set; }
 
-    internal bool DisableTimestamp { get; set; }
-
     internal Resource Resource
     {
         get => field ??= this.ParentProvider.GetResource();

src/OpenTelemetry.Exporter.Prometheus.HttpListener/Internal/PrometheusExporterOptions.cs

@@ -10,7 +10,10 @@ namespace OpenTelemetry.Exporter.Prometheus;
 /// </summary>
 internal sealed class PrometheusExporterOptions
 {
-    private int scrapeResponseCacheDurationMilliseconds = 300;
+    public PrometheusExporterOptions()
+    {
+        this.ScrapeResponseCacheDurationMilliseconds = 300;
+    }
 
     /// <summary>
     /// Gets or sets the cache duration in milliseconds for scrape responses. Default value: 300.
@@ -20,22 +23,16 @@ internal sealed class PrometheusExporterOptions
     /// </remarks>
     public int ScrapeResponseCacheDurationMilliseconds
     {
-        get => this.scrapeResponseCacheDurationMilliseconds;
+        get => field;
         set
         {
             Guard.ThrowIfOutOfRange(value, min: 0);
-
-            this.scrapeResponseCacheDurationMilliseconds = value;
+            field = value;
         }
     }
 
     /// <summary>
     /// Gets or sets a value indicating whether addition of _total suffix for counter metric names is disabled. Default value: <see langword="false"/>.
     /// </summary>
     public bool DisableTotalNameSuffixForCounters { get; set; }
-
-    /// <summary>
-    /// Gets or sets a value indicating whether timestamps should be disabled. Default value: <see langword="false"/>.
-    /// </summary>
-    public bool DisableTimestamp { get; set; }
 }

src/OpenTelemetry.Exporter.Prometheus.HttpListener/Internal/PrometheusSerializer.cs

@@ -351,32 +351,6 @@ public static int WriteScopeInfo(byte[] buffer, int cursor, string scopeName)
         return cursor;
     }
 
-    [MethodImpl(MethodImplOptions.AggressiveInlining)]
-    public static int WriteTimestamp(byte[] buffer, int cursor, long value, bool useOpenMetrics)
-    {
-        if (useOpenMetrics)
-        {
-            cursor = WriteLong(buffer, cursor, value / 1000);
-            buffer[cursor++] = unchecked((byte)'.');
-
-            var millis = value % 1000;
-
-            if (millis < 100)
-            {
-                buffer[cursor++] = unchecked((byte)'0');
-            }
-
-            if (millis < 10)
-            {
-                buffer[cursor++] = unchecked((byte)'0');
-            }
-
-            return WriteLong(buffer, cursor, millis);
-        }
-
-        return WriteLong(buffer, cursor, value);
-    }
-
     [MethodImpl(MethodImplOptions.AggressiveInlining)]
     public static int WriteTags(byte[] buffer, int cursor, Metric metric, ReadOnlyTagCollection tags, bool writeEnclosingBraces = true)
     {

src/OpenTelemetry.Exporter.Prometheus.HttpListener/Internal/PrometheusSerializerExt.cs

@@ -22,7 +22,7 @@ public static bool CanWriteMetric(Metric metric)
         return true;
     }
 
-    public static int WriteMetric(byte[] buffer, int cursor, Metric metric, PrometheusMetric prometheusMetric, bool openMetricsRequested, bool disableTimestamp)
+    public static int WriteMetric(byte[] buffer, int cursor, Metric metric, PrometheusMetric prometheusMetric, bool openMetricsRequested)
     {
         cursor = WriteTypeMetadata(buffer, cursor, prometheusMetric, openMetricsRequested);
         cursor = WriteUnitMetadata(buffer, cursor, prometheusMetric, openMetricsRequested);
@@ -32,8 +32,6 @@ public static int WriteMetric(byte[] buffer, int cursor, Metric metric, Promethe
         {
             foreach (ref readonly var metricPoint in metric.GetMetricPoints())
             {
-                var timestamp = metricPoint.EndTime.ToUnixTimeMilliseconds();
-
                 // Counter and Gauge
                 cursor = WriteMetricName(buffer, cursor, prometheusMetric, openMetricsRequested);
                 cursor = WriteTags(buffer, cursor, metric, metricPoint.Tags);
@@ -45,31 +43,15 @@ public static int WriteMetric(byte[] buffer, int cursor, Metric metric, Promethe
                 // for each MetricPoint
                 if (((int)metric.MetricType & 0b_0000_1111) == 0x0a /* I8 */)
                 {
-                    if (metric.MetricType.IsSum())
-                    {
-                        cursor = WriteLong(buffer, cursor, metricPoint.GetSumLong());
-                    }
-                    else
-                    {
-                        cursor = WriteLong(buffer, cursor, metricPoint.GetGaugeLastValueLong());
-                    }
+                    cursor = metric.MetricType.IsSum()
+                        ? WriteLong(buffer, cursor, metricPoint.GetSumLong())
+                        : WriteLong(buffer, cursor, metricPoint.GetGaugeLastValueLong());
                 }
                 else
                 {
-                    if (metric.MetricType.IsSum())
-                    {
-                        cursor = WriteDouble(buffer, cursor, metricPoint.GetSumDouble());
-                    }
-                    else
-                    {
-                        cursor = WriteDouble(buffer, cursor, metricPoint.GetGaugeLastValueDouble());
-                    }
-                }
-
-                if (!disableTimestamp)
-                {
-                    buffer[cursor++] = unchecked((byte)' ');
-                    cursor = WriteTimestamp(buffer, cursor, timestamp, openMetricsRequested);
+                    cursor = metric.MetricType.IsSum()
+                        ? WriteDouble(buffer, cursor, metricPoint.GetSumDouble())
+                        : WriteDouble(buffer, cursor, metricPoint.GetGaugeLastValueDouble());
                 }
 
                 buffer[cursor++] = ASCII_LINEFEED;
@@ -80,7 +62,6 @@ public static int WriteMetric(byte[] buffer, int cursor, Metric metric, Promethe
             foreach (ref readonly var metricPoint in metric.GetMetricPoints())
             {
                 var tags = metricPoint.Tags;
-                var timestamp = metricPoint.EndTime.ToUnixTimeMilliseconds();
 
                 long totalCount = 0;
                 foreach (var histogramMeasurement in metricPoint.GetHistogramBuckets())
@@ -93,25 +74,14 @@ public static int WriteMetric(byte[] buffer, int cursor, Metric metric, Promethe
 
                     cursor = WriteAsciiStringNoEscape(buffer, cursor, "le=\"");
 
-                    if (histogramMeasurement.ExplicitBound != double.PositiveInfinity)
-                    {
-                        cursor = WriteDouble(buffer, cursor, histogramMeasurement.ExplicitBound);
-                    }
-                    else
-                    {
-                        cursor = WriteAsciiStringNoEscape(buffer, cursor, "+Inf");
-                    }
+                    cursor = histogramMeasurement.ExplicitBound != double.PositiveInfinity
+                        ? WriteDouble(buffer, cursor, histogramMeasurement.ExplicitBound)
+                        : WriteAsciiStringNoEscape(buffer, cursor, "+Inf");
 
                     cursor = WriteAsciiStringNoEscape(buffer, cursor, "\"} ");
 
                     cursor = WriteLong(buffer, cursor, totalCount);
 
-                    if (!disableTimestamp)
-                    {
-                        buffer[cursor++] = unchecked((byte)' ');
-                        cursor = WriteTimestamp(buffer, cursor, timestamp, openMetricsRequested);
-                    }
-
                     buffer[cursor++] = ASCII_LINEFEED;
                 }
 
@@ -124,12 +94,6 @@ public static int WriteMetric(byte[] buffer, int cursor, Metric metric, Promethe
 
                 cursor = WriteDouble(buffer, cursor, metricPoint.GetHistogramSum());
 
-                if (!disableTimestamp)
-                {
-                    buffer[cursor++] = unchecked((byte)' ');
-                    cursor = WriteTimestamp(buffer, cursor, timestamp, openMetricsRequested);
-                }
-
                 buffer[cursor++] = ASCII_LINEFEED;
 
                 // Histogram count
@@ -141,12 +105,6 @@ public static int WriteMetric(byte[] buffer, int cursor, Metric metric, Promethe
 
                 cursor = WriteLong(buffer, cursor, metricPoint.GetHistogramCount());
 
-                if (!disableTimestamp)
-                {
-                    buffer[cursor++] = unchecked((byte)' ');
-                    cursor = WriteTimestamp(buffer, cursor, timestamp, openMetricsRequested);
-                }
-
                 buffer[cursor++] = ASCII_LINEFEED;
             }
         }

src/OpenTelemetry.Exporter.Prometheus.HttpListener/PrometheusHttpListenerMeterProviderBuilderExtensions.cs

@@ -69,7 +69,6 @@ private static BaseExportingMetricReader BuildPrometheusHttpListenerMetricReader
         {
             ScrapeResponseCacheDurationMilliseconds = 0,
             DisableTotalNameSuffixForCounters = options.DisableTotalNameSuffixForCounters,
-            DisableTimestamp = options.DisableTimestamp,
         });
 
         var reader = new BaseExportingMetricReader(exporter)

src/OpenTelemetry.Exporter.Prometheus.HttpListener/PrometheusHttpListenerOptions.cs

@@ -37,11 +37,6 @@ public class PrometheusHttpListenerOptions
     /// </summary>
     public bool DisableTotalNameSuffixForCounters { get; set; }
 
-    /// <summary>
-    /// Gets or sets a value indicating whether timestamps should be disabled. Default value: <see langword="false"/>.
-    /// </summary>
-    public bool DisableTimestamp { get; set; }
-
     /// <summary>
     /// Gets or sets the URI (Uniform Resource Identifier) prefixes to use for the http listener.
     /// Default value: <c>["http://localhost:9464/"]</c>.

test/Benchmarks/Exporter/PrometheusSerializerBenchmarks.cs

@@ -50,7 +50,6 @@ public void GlobalCleanup()
         this.meterProvider?.Dispose();
     }
 
-    // TODO: this has a dependency on https://github.com/open-telemetry/opentelemetry-dotnet/issues/2361
     [Benchmark]
     public void WriteMetric()
     {
@@ -59,7 +58,7 @@ public void WriteMetric()
             var cursor = 0;
             foreach (var metric in this.metrics)
             {
-                cursor = PrometheusSerializer.WriteMetric(this.buffer, cursor, metric, this.GetPrometheusMetric(metric), openMetricsRequested: false, disableTimestamp: false);
+                cursor = PrometheusSerializer.WriteMetric(this.buffer, cursor, metric, this.GetPrometheusMetric(metric), openMetricsRequested: false);
             }
         }
     }